Skip to content

reorg #34

@shaunc

Description

@shaunc

@BryanCrotaz @lcpriest @andrewpye

btw ... branch I'm working on:

https://github.com/shaunc/ember-grid/tree/reorg

Hopefully will finish this weekend. Its as of yet still far from working.

Goals:

  1. support css auto & 100% for width/height of main and move primarily to css except for explicit programmatic height/width.
  2. replace "teleportation" of declarative content using tools developed in ember-declarative.

Still looks like a mess (especially on windows I sure as I haven't yet looked at it). I blew away all the explicit measurement code... but there is a dilemma relying on css. The idea of "auto" was that dimension should conform to content size, which works with ember-grid being table layout (still keeping display as flex), but then this requires display:table in whole and also position:relative for scroll-container (etc). Then rendering with 100% (fill parent) and trying to scroll is broken.

My current plan is to fix by flipping position:relative/position:absolute on scroll wrappers and seeing if size changes to detect whether whole is "auto" or percentage of parent, then setting a class accordingly which will trigger appropriate css changes -- not entirely css but at least not trying to calculate all the measurements.

ember-declarative sending of content seems to be working, which did allow cleaning out some fragile code.

I will try to get this working including some tests on the weekend. If you have other plans/deadlines please comment to coordinate.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions