chore: centralize shared hooks and publish certkit@nightly cask#128
chore: centralize shared hooks and publish certkit@nightly cask#128danielewood merged 22 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Centralizes this repo’s pre-commit hook definitions by consuming them from the shared sensiblebit/.github repository, while keeping repo-specific markdownlint rules via .markdownlint.yaml.
Changes:
- Removed locally-defined/external hook repos from
.pre-commit-config.yamland switched to a single shared hook source (sensiblebit/.github). - Added shared
markdownlinthook invocation while preserving local configuration (--config .markdownlint.yaml). - Updated
CLAUDE.md’s documented configured-hook list to reflect the new setup (but it still needs to be brought fully in sync).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
CLAUDE.md |
Updates documented pre-commit hook list (currently incomplete vs actual config). |
.pre-commit-config.yaml |
Removes local/external repos and pins all hooks to sensiblebit/.github, adding shared markdownlint with repo-specific config args. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Addressed the review comments in commit
Validation rerun:
|
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 83717383b9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 615837d3c2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 621f34f572
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7f031524dd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Summary
.pre-commit-config.yamlhttps://github.com/sensiblebit/.github.githubmain commitddffb3a(includes markdownlint hook + golangci cache-parity updates)go-mod-update,npm-update) before lint/build/test hooksNightly Caskworkflow that updatesCasks/certkit@nightly.rbinsensiblebit/homebrew-tapon every push tomainnightlyprerelease tag, and updates cask checksumscertkitcommand and declaresconflicts_with cask: "certkit"CHANGELOG.mdRelated
Runtime requirement
HOMEBREW_TAP_TOKENsecret to push updates tosensiblebit/homebrew-tapValidation
pre-commit run --all-files