can't delete the addres

[zrxzzz]

Problem

The addr_del function executes without error during testing, but it does not successfully remove the IP address from the network interface. The test reports ok, yet the IP address remains on the interface.

Test Code:

Before test I set up a veth peer

root@tcy-VMware-Virtual-Platform:~# sudo ip link add name vethhost type veth peer name vethhost1
root@tcy-VMware-Virtual-Platform:~# sudo ip link set vethhost up
root@tcy-VMware-Virtual-Platform:~# sudo ip link set vethhost1 up

#[tokio::test]
async fn test_addr_del() {
        let link = link::link_by_name("vethhost").await.unwrap();
        //let res = addr_del(link.header.index).await;
        let res = addr_add(
            link.header.index,
            IpAddr::V4(Ipv4Addr::new(198, 19, 249, 211)),  
            16  // prefix_len
        ).await;
        println!("res: {:?}", res);
    }
#[tokio::test]
async fn test_addr_del() {
    let link = link::link_by_name("vethhost").await.unwrap();
    let res = addr_del(link.header.index).await;
    println!("res: {:?}", res);
}

Code:

pub fn get_handle() -> anyhow::Result<Option<Handle>>{
    let (connection, handle, _) = new_connection().map_err(|e| anyhow!("Failed to create rtnetlink connection: {}", e))?;
    tokio::spawn(connection);
    Ok(Some(handle))
}
pub async fn addr_add(index: u32, address: IpAddr, prefix_len: u8) -> anyhow::Result<()>{
    let handle = get_handle()?.ok_or_else(|| anyhow!("Cannot get handle"))?;
    let address_handle = handle.address();

    address_handle.add(index, address, prefix_len).execute().await?;
    
    Ok(())
}

pub async fn addr_del(index: u32, address: IpAddr) -> anyhow::Result<()>{
    let handle = get_handle()?.ok_or_else(|| anyhow!("Cannot get handle"))?;
    let address_handle = handle.address();

    let mut req = address_handle.get().set_address_filter(address);
    let mut msg = req.message_mut();
    msg.header.index=index;
    //let mut address_message = AddressMessage::default();
    //address_message.header.index = index;    
    //address_handle.del(address_message).execute().await?;
    address_handle.del(msg.clone()).execute().await?;
    Ok(())
}

Result:

although can past the test , but actually it can't delete the ip address

I can add the ip ,but can't delete

• after add test:

• after del test:

you can see the ip still here. can you help me to solve this issue?

[reimarstier]

Hey, I accidentally found your issue here while trying to achieve the same thing. I noticed that the approach with set_address_filter always returned an empty message in my case. Following up on your uncommented approach, the following worked for me:

pub struct NetworkInterfaceManager {
    handle: rtnetlink::Handle,
}
impl NetworkInterfaceManager {
    pub fn create() -> Result<NetworkInterfaceManagerRef, Error> {
        let (connection, handle, _) = rtnetlink::new_connection()
            .map_err(|cause| Error::Connecting { cause })?;
        tokio::spawn(connection);

        Ok(Arc::new(Self { handle }))
    }
  
  pub async fn delete_address(&self, interface: &Interface, address: IpAddr, prefix_len: u8) -> Result<Interface, Error> {
      let address_family = match address {
          IpAddr::V4(_) => {
              AddressFamily::Inet
          }
          IpAddr::V6(_) => {
              AddressFamily::Inet6
          }
      };
      let mut address_message = AddressMessage::default();
      address_message.header.index = interface.index;
      address_message.header.prefix_len = prefix_len;
      address_message.header.family = address_family;
      address_message.attributes = vec![AddressAttribute::Address(address)];
  
      self.handle.address().del(address_message.clone()).execute()
          .await
          .map_err(|error| Error::ModificationFailure { name: interface.name.clone(), cause: format!("Failed to delete ip address. {}", error) })?;
      let interface = self.try_find_interface(&interface.name).await?;
  
      Ok(interface)
  }
}

But lacking any other examples I'm still curious if this is how it is intended to be used...

Edit: This is a duplicate of #80 by the way. And there is an example here flushing all addresses.

[acst1223]

I was also investigating the address deletion and I bumped into this issue. For @zrxzzz 's case, you just need to add the prefix_len and family to make it work. Under msg.header.index=index; add:

    msg.header.prefix_len=16;
    msg.header.family=AddressFamily::Inet;

But indeed the way to delete the address is much more complex than adding one with current library and there's no example. Let me see if I can do something for this.