Refactorings for rustc_codegen_ssa

[bjorn3]

This is a list of things I noticed in rustc_codegen_{utils,ssa} which I did like to be changed.

• Move https://doc.rust-lang.org/nightly/nightly-rustc/rustc_codegen_utils/symbol_names/index.html to rustc_codegen_ssa.
• Remove https://doc.rust-lang.org/nightly/nightly-rustc/src/rustc_codegen_utils/lib.rs.html#64 (now unused)
• https://doc.rust-lang.org/nightly/nightly-rustc/rustc_codegen_ssa/debuginfo/enum.FunctionDebugContext.html
  • Inline debuginfo_disabled_message and should_be_ignored_message into as_ref.
• https://doc.rust-lang.org/nightly/nightly-rustc/rustc_codegen_ssa/debuginfo/struct.FunctionDebugContextData.html
  • Remove the Cell from the field source_locations_enabled and adapt several functions to take a mutable reference to FunctionDebugContext{,Data} instead.

---

Edit:

• https://doc.rust-lang.org/nightly/nightly-rustc/rustc_codegen_ssa/traits/backend/trait.BackendTypes.html Context is not used inside rustc_codegen_ssa
• https://doc.rust-lang.org/nightly/nightly-rustc/rustc_codegen_ssa/traits/type_/trait.BaseTypeMethods.html https://doc.rust-lang.org/nightly/nightly-rustc/rustc_codegen_llvm/context/struct.CodegenCx.html#method.set_struct_body Why is set_struct_body even a thing?
• https://doc.rust-lang.org/nightly/nightly-rustc/rustc_codegen_ssa/traits/consts/trait.ConstMethods.html All methods take &self, but a codegen backend may need to mutate stuff to create values.
• https://doc.rust-lang.org/nightly/nightly-rustc/rustc_codegen_ssa/traits/statics/trait.StaticMethods.html All methods take &self, but a codegen backend may need to mutate stuff to create values.

Edit: update for current status

[bjorn3]

cc @eddyb

[eddyb]

I agree with all of these.

There are also comments on #55627 that were left unaddressed, to avoid bitrot, that could be done now.

cc @denismerigoux @sunfishcode @michaelwoerister

[bjorn3]

The following comments from #55627 by @eddyb likely still need to be addressed (none confirmed yet, because of the amount)

• rustc_codegen_llvm: traitification of LLVM-specific CodegenCx and Builder methods #55627 (comment)
• rustc_codegen_llvm: traitification of LLVM-specific CodegenCx and Builder methods #55627 (comment)
• rustc_codegen_llvm: traitification of LLVM-specific CodegenCx and Builder methods #55627 (comment)
• rustc_codegen_llvm: traitification of LLVM-specific CodegenCx and Builder methods #55627 (comment)
• rustc_codegen_llvm: traitification of LLVM-specific CodegenCx and Builder methods #55627 (comment)
• rustc_codegen_llvm: traitification of LLVM-specific CodegenCx and Builder methods #55627 (comment)
• rustc_codegen_llvm: traitification of LLVM-specific CodegenCx and Builder methods #55627 (comment)
• rustc_codegen_llvm: traitification of LLVM-specific CodegenCx and Builder methods #55627 (comment)
• rustc_codegen_llvm: traitification of LLVM-specific CodegenCx and Builder methods #55627 (comment)
• rustc_codegen_llvm: traitification of LLVM-specific CodegenCx and Builder methods #55627 (comment)
• rustc_codegen_llvm: traitification of LLVM-specific CodegenCx and Builder methods #55627 (comment)
• rustc_codegen_llvm: traitification of LLVM-specific CodegenCx and Builder methods #55627 (comment)
• rustc_codegen_llvm: traitification of LLVM-specific CodegenCx and Builder methods #55627 (comment)
• rustc_codegen_llvm: traitification of LLVM-specific CodegenCx and Builder methods #55627 (comment)
• rustc_codegen_llvm: traitification of LLVM-specific CodegenCx and Builder methods #55627 (comment)
• rustc_codegen_llvm: traitification of LLVM-specific CodegenCx and Builder methods #55627 (comment)
• rustc_codegen_llvm: traitification of LLVM-specific CodegenCx and Builder methods #55627 (comment)
• rustc_codegen_llvm: traitification of LLVM-specific CodegenCx and Builder methods #55627 (comment)
• rustc_codegen_llvm: traitification of LLVM-specific CodegenCx and Builder methods #55627 (comment)
• rustc_codegen_llvm: traitification of LLVM-specific CodegenCx and Builder methods #55627 (comment)
• rustc_codegen_llvm: traitification of LLVM-specific CodegenCx and Builder methods #55627 (comment)
• rustc_codegen_llvm: traitification of LLVM-specific CodegenCx and Builder methods #55627 (comment)
• rustc_codegen_llvm: traitification of LLVM-specific CodegenCx and Builder methods #55627 (comment)
• rustc_codegen_llvm: traitification of LLVM-specific CodegenCx and Builder methods #55627 (comment)
• rustc_codegen_llvm: traitification of LLVM-specific CodegenCx and Builder methods #55627 (comment)
• rustc_codegen_llvm: traitification of LLVM-specific CodegenCx and Builder methods #55627 (comment)
• rustc_codegen_llvm: traitification of LLVM-specific CodegenCx and Builder methods #55627 (comment)

[bjorn3]

@rustbot modify labels:+A-cranelift