Rollup highlight is partly broken for rollups containing an unapproved PR

[Zalathar]

At the time I'm writing this, rust-lang/rust#151767 is a rollup that contains a PR that was later unapproved (rust-lang/rust#151449).

Separate from the question of how to handle that particular scenario, I noticed that it also triggers a bug in hover highlighting of rolled-up PRs. Instead of highlighting all of them, it highlights only a subset of rolled-up PRs.

The subset changes non-deterministically on every page reload, but seems to be consistent until the next reload.

I think what's happening is that JS is trying to highlight the unapproved PR, which throws an exception, preventing highlight of any PRs that appear after the approved one in data-rollup-pr-members.

On hovering over the rollup, the error I see in my browser JS console is:

TypeError: null is not an object (evaluating 'tbody.querySelector(`tr[data-pr-number="${rollupPrMember}"]`).classList')

Clicking on the rollup appears to successfully select all rolled-up PRs, except for the unapproved one.

[Zalathar]

[Kobzol]

Thank you for the report! I'll fix it.

Also, I had in my TODO list to handle the scenario you describe. Once a PR from a rollup is unapproved, I'll teach bors to unapprove the whole rollup.