From 48d6d7fcb31dc86991f73d28a29d09cde7d8ee34 Mon Sep 17 00:00:00 2001 From: Tony Deng Date: Tue, 19 Aug 2025 12:01:43 -0700 Subject: [PATCH 1/3] update args to enable None as input for devbox_create_params.DevboxCreateParams because dbx works with empty --- src/runloop_api_client/resources/devboxes/devboxes.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/runloop_api_client/resources/devboxes/devboxes.py b/src/runloop_api_client/resources/devboxes/devboxes.py index 7aee61337..c59157367 100644 --- a/src/runloop_api_client/resources/devboxes/devboxes.py +++ b/src/runloop_api_client/resources/devboxes/devboxes.py @@ -430,7 +430,7 @@ def is_done_booting(devbox: DevboxView) -> bool: def create_and_await_running( self, *, - create_args: devbox_create_params.DevboxCreateParams, + create_args: devbox_create_params.DevboxCreateParams | None = None, request_args: DevboxRequestArgs | None = None, ) -> DevboxView: """Create a new devbox and wait for it to be in running state. @@ -454,7 +454,7 @@ def create_and_await_running( # Pass all create_args to the underlying create method devbox = self.create( - **create_args, + **(create_args or {}), extra_headers=request_args.get("extra_headers", None), extra_query=request_args.get("extra_query", None), extra_body=request_args.get("extra_body", None), @@ -1558,7 +1558,7 @@ async def retrieve( async def create_and_await_running( self, *, - create_args: devbox_create_params.DevboxCreateParams, + create_args: devbox_create_params.DevboxCreateParams | None = None, request_args: DevboxRequestArgs | None = None, ) -> DevboxView: """Create a devbox and wait for it to be in running state. @@ -1577,7 +1577,7 @@ async def create_and_await_running( RunloopError: If devbox enters a non-running terminal state """ # Pass all create_args to the underlying create method - devbox = await self.create(**create_args) + devbox = await self.create(**(create_args or {})) # Extract polling config and other request args if request_args is None: From ddea5c4b92b0af9b41ba4bee1dcc92c8b840b427 Mon Sep 17 00:00:00 2001 From: Tony Deng Date: Tue, 19 Aug 2025 12:04:49 -0700 Subject: [PATCH 2/3] better default --- src/runloop_api_client/resources/devboxes/devboxes.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/runloop_api_client/resources/devboxes/devboxes.py b/src/runloop_api_client/resources/devboxes/devboxes.py index c59157367..d5f9d08e2 100644 --- a/src/runloop_api_client/resources/devboxes/devboxes.py +++ b/src/runloop_api_client/resources/devboxes/devboxes.py @@ -430,7 +430,7 @@ def is_done_booting(devbox: DevboxView) -> bool: def create_and_await_running( self, *, - create_args: devbox_create_params.DevboxCreateParams | None = None, + create_args: devbox_create_params.DevboxCreateParams = {}, request_args: DevboxRequestArgs | None = None, ) -> DevboxView: """Create a new devbox and wait for it to be in running state. @@ -454,7 +454,7 @@ def create_and_await_running( # Pass all create_args to the underlying create method devbox = self.create( - **(create_args or {}), + **create_args, extra_headers=request_args.get("extra_headers", None), extra_query=request_args.get("extra_query", None), extra_body=request_args.get("extra_body", None), @@ -1558,7 +1558,7 @@ async def retrieve( async def create_and_await_running( self, *, - create_args: devbox_create_params.DevboxCreateParams | None = None, + create_args: devbox_create_params.DevboxCreateParams = {}, request_args: DevboxRequestArgs | None = None, ) -> DevboxView: """Create a devbox and wait for it to be in running state. @@ -1577,7 +1577,7 @@ async def create_and_await_running( RunloopError: If devbox enters a non-running terminal state """ # Pass all create_args to the underlying create method - devbox = await self.create(**(create_args or {})) + devbox = await self.create(**create_args) # Extract polling config and other request args if request_args is None: From 4b75902a9d7f65beffd1393a77c87b1b77ab49bb Mon Sep 17 00:00:00 2001 From: Tony Deng Date: Tue, 19 Aug 2025 12:54:27 -0700 Subject: [PATCH 3/3] avoid default dicts to be more pythonic --- src/runloop_api_client/resources/devboxes/devboxes.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/runloop_api_client/resources/devboxes/devboxes.py b/src/runloop_api_client/resources/devboxes/devboxes.py index d5f9d08e2..c59157367 100644 --- a/src/runloop_api_client/resources/devboxes/devboxes.py +++ b/src/runloop_api_client/resources/devboxes/devboxes.py @@ -430,7 +430,7 @@ def is_done_booting(devbox: DevboxView) -> bool: def create_and_await_running( self, *, - create_args: devbox_create_params.DevboxCreateParams = {}, + create_args: devbox_create_params.DevboxCreateParams | None = None, request_args: DevboxRequestArgs | None = None, ) -> DevboxView: """Create a new devbox and wait for it to be in running state. @@ -454,7 +454,7 @@ def create_and_await_running( # Pass all create_args to the underlying create method devbox = self.create( - **create_args, + **(create_args or {}), extra_headers=request_args.get("extra_headers", None), extra_query=request_args.get("extra_query", None), extra_body=request_args.get("extra_body", None), @@ -1558,7 +1558,7 @@ async def retrieve( async def create_and_await_running( self, *, - create_args: devbox_create_params.DevboxCreateParams = {}, + create_args: devbox_create_params.DevboxCreateParams | None = None, request_args: DevboxRequestArgs | None = None, ) -> DevboxView: """Create a devbox and wait for it to be in running state. @@ -1577,7 +1577,7 @@ async def create_and_await_running( RunloopError: If devbox enters a non-running terminal state """ # Pass all create_args to the underlying create method - devbox = await self.create(**create_args) + devbox = await self.create(**(create_args or {})) # Extract polling config and other request args if request_args is None: