From 42f598252699b7e62110d4c612bd024feb1ffac5 Mon Sep 17 00:00:00 2001 From: Douglas Eichelberger Date: Thu, 5 Mar 2026 15:02:57 -0800 Subject: [PATCH 1/2] Fix typos: POSIBLE_TYPES -> POSSIBLE_TYPES, configuratoin -> configuration --- lib/packs/cli.rb | 10 +++++----- lib/packs/private.rb | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/packs/cli.rb b/lib/packs/cli.rb index 769c3f3..0ea5ba9 100644 --- a/lib/packs/cli.rb +++ b/lib/packs/cli.rb @@ -39,10 +39,10 @@ def add_dependency(from_pack, to_pack) exit_successfully end - POSIBLE_TYPES = T.let(%w[dependency privacy layer], T::Array[String]) + POSSIBLE_TYPES = T.let(%w[dependency privacy layer], T::Array[String]) desc 'list_top_violations type [ packs/your_pack ]', 'List the top violations of a specific type for packs/your_pack.' long_desc <<~LONG_DESC - Possible types are: #{POSIBLE_TYPES.join(', ')}. + Possible types are: #{POSSIBLE_TYPES.join(', ')}. Want to see who is depending on you? Not sure how your pack's code is being used in an unstated way? You can use this command to list the top dependency violations. @@ -60,7 +60,7 @@ def add_dependency(from_pack, to_pack) ).void end def list_top_violations(type, pack_name = nil) - raise StandardError, "Invalid type #{type}. Possible types are: #{POSIBLE_TYPES.join(', ')}" unless POSIBLE_TYPES.include?(type) + raise StandardError, "Invalid type #{type}. Possible types are: #{POSSIBLE_TYPES.join(', ')}" unless POSSIBLE_TYPES.include?(type) Packs.list_top_violations( type: type, @@ -135,8 +135,8 @@ def update sig { params(pack_names: String).void } def get_info(*pack_names) selected_types = options[:types].to_s.downcase.split(',') - invalid_types = selected_types - POSIBLE_TYPES - raise StandardError, "Invalid type(s): #{invalid_types.join(', ')}. Possible types are: #{POSIBLE_TYPES.join(', ')}" unless invalid_types.empty? + invalid_types = selected_types - POSSIBLE_TYPES + raise StandardError, "Invalid type(s): #{invalid_types.join(', ')}. Possible types are: #{POSSIBLE_TYPES.join(', ')}" unless invalid_types.empty? Private.get_info( packs: parse_pack_names(pack_names), diff --git a/lib/packs/private.rb b/lib/packs/private.rb index 0e63de6..9ecfa87 100644 --- a/lib/packs/private.rb +++ b/lib/packs/private.rb @@ -530,7 +530,7 @@ def self.load_client_configuration def self.bust_cache! Packs.config.bust_cache! # This comes explicitly after `Packs.config.bust_cache!` because - # otherwise `Packs.config` will attempt to reload the client configuratoin. + # otherwise `Packs.config` will attempt to reload the client configuration. @loaded_client_configuration = false end From 3a520e6137f75e11aa6b7a74c9db215c6a46fb27 Mon Sep 17 00:00:00 2001 From: Douglas Eichelberger Date: Thu, 5 Mar 2026 15:03:26 -0800 Subject: [PATCH 2/2] Fix grammatical issues in documentation and comments --- README.md | 2 +- advanced_usage.md | 2 +- lib/packs/cli.rb | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 7bfb2d1..f41c209 100644 --- a/README.md +++ b/README.md @@ -90,7 +90,7 @@ Make sure there are no spaces between the comma-separated list of paths of direc `bin/packs move packs/destination_pack path/to/file.rb path/to/directory` This is used for moving files into a pack (the pack must already exist). -Note this works for moving files to packs from the monolith or from other packs +Note this works for moving files to packs from the monolith or from other packs. Make sure there are no spaces between the comma-separated list of paths of directories. diff --git a/advanced_usage.md b/advanced_usage.md index 5d5f52d..7a2cd26 100644 --- a/advanced_usage.md +++ b/advanced_usage.md @@ -13,7 +13,7 @@ Packs.create_pack!( ### Per-file Processors Your application may have specific needs when moving files. `Packs` gives a way to inject application-specific behavior into the file move process. -You can pass in an array of application specific behavior into the `per_file_processors` parameter of the main method. +You can pass in an array of application-specific behavior into the `per_file_processors` parameter of the main method. See `rubocop_post_processor.rb` as an example of renaming files in `.rubocop_todo.yml` automatically, which is something you may want to do (as you do not want to fix all style errors when you're just moving a file). diff --git a/lib/packs/cli.rb b/lib/packs/cli.rb index 0ea5ba9..045c4f2 100644 --- a/lib/packs/cli.rb +++ b/lib/packs/cli.rb @@ -85,7 +85,7 @@ def make_public(*paths) desc 'move packs/destination_pack path/to/file.rb path/to/directory', 'Move files or directories from one pack to another' long_desc <<~LONG_DESC This is used for moving files into a pack (the pack must already exist). - Note this works for moving files to packs from the monolith or from other packs + Note this works for moving files to packs from the monolith or from other packs. Make sure there are no spaces between the comma-separated list of paths of directories. LONG_DESC