From a3c806e487919451556126f2233cdcf4e6876c78 Mon Sep 17 00:00:00 2001 From: LongForWisdom Date: Thu, 5 Oct 2023 14:55:41 +0100 Subject: [PATCH 1/5] Draft of status-change checklists for RPIP editors. --- meta/rpip-status-change-checklists.md | 54 +++++++++++++++++++++++++++ 1 file changed, 54 insertions(+) create mode 100644 meta/rpip-status-change-checklists.md diff --git a/meta/rpip-status-change-checklists.md b/meta/rpip-status-change-checklists.md new file mode 100644 index 00000000..bac41109 --- /dev/null +++ b/meta/rpip-status-change-checklists.md @@ -0,0 +1,54 @@ + +# RPIP Status Change Checklists + +## Draft Checklist + +- [ ] Ensure that the RPIP preamble is present and correctly formatted as per RPIP-1. + - [ ] Add RPIP number if not present. + - [ ] Check `title` is a few words, and not a complete sentence. + - [ ] Check `author` field matches convention. + - [ ] Check `discussions-to` field is present, and links to the Rocket Pool forum. This field should consist of a single URL. + - [ ] Check `status` is set to 'Draft' + - [ ] Check that `type` is a valid value. + - [ ] If the `type` is 'protocol', ensure a `category` is present. + - [ ] Check that `created` is set to the day of the RPIP number assignment, in the YYYY-MM-DD format. +- [ ] Ensure that the RPIP matches the RPIP template in terms of layout. +- [ ] Ensure that the RPIP author is content with the draft being published on the RPIPs portal in its current state. + +## Finalize Checklist +- [ ] Ensure that the RPIP Draft Checklist has been completed for this RPIP. +- [ ] Ensure that the RPIP preamble is present and correctly formatted for a finalized RPIP. + - [ ] Check `status` is set to 'Final' +- [ ] Ensure that the finalization PR is the only open pull request modifying the RPIP in the official RPIP repository. +- [ ] Editor Responsibilities + - [ ] Check that the RPIP is ready, sound and complete. + - [ ] Check that the ideas within the RPIP make technical sense. + - [ ] Check that the RPIP title accurately describes the RPIP content. + - [ ] Check the RPIP for language, markup, and code style. +- [ ] Ensure that the RPIP author has confirmed the RPIP is ready to be finalized. +- [ ] Ensure that the RPIP editors have confirmed the RPIP is ready to be finalized. + +## Withdrawn Checklist +- [ ] Ensure that the RPIP author has confirmed that they are withdrawing the RPIP. +- [ ] Check `status` is set to 'Withdrawn' + +## Stagnant Checklist +- [ ] Ensure that RPIP editors are in general agreement that the RPIP has been inactive for too long. +- [ ] Attempt to confirm the status change with the author if they are still a regular in the Rocket Pool community. +- [ ] Check `status` is set to 'Stagnant' + +## Living Update Checklist +- [ ] Check `status` is set to 'Living' +- [ ] Add or update the `updated` date field in the format of YYYY-MM-DD. +- [ ] Confirm any associated content changes with the other RPIP editors. + +## Vote Update Checklist +- [ ] Add or update the `vote-to` field. The value should be a URL pointing to the outcome of the vote. +- [ ] Add or update the `vote-date` field. The date should be in YYYY-MM-DD format, and should match the date the vote concluded. +- [ ] Add the `vote-result` field. This should be the vote result: 'Passed' or 'Failed' + - [ ] This field should not be updated to 'Failed' for Living RPIPs that have previously had successful votes. + + + + + From cc3588c9211bbdae9b9edb1980c9404209f39653 Mon Sep 17 00:00:00 2001 From: LongForWisdom Date: Thu, 5 Oct 2023 15:51:52 +0100 Subject: [PATCH 2/5] Rocket Pool vote and vote-text checklists --- meta/vote-checklist.md | 15 +++++++++++++++ meta/vote-text-checklist.md | 11 +++++++++++ 2 files changed, 26 insertions(+) create mode 100644 meta/vote-checklist.md create mode 100644 meta/vote-text-checklist.md diff --git a/meta/vote-checklist.md b/meta/vote-checklist.md new file mode 100644 index 00000000..fe13ed32 --- /dev/null +++ b/meta/vote-checklist.md @@ -0,0 +1,15 @@ + +# Rocket Pool Vote Checklist + +## If vote has attached RPIP +- [ ] The RPIP is present in the RPIP github repository. +- [ ] The RPIP Draft Checklist has been completed for this RPIP. +- [ ] RPIP has been given `final` status in the main branch of the official RPIP repository. +- [ ] The RPIP Finalize Checklist has been completed for this RPIP. + +## Always +- [ ] The vote has met the requirement for 'promising community sentiment' + - Usually demonstrated by a poll on the RP forum that is open for at least 7 days. +- [ ] Vote text has been completed for this vote. +- [ ] The Vote Text checklist has been completed for the final iteration of the vote text. +- [ ] Think about this vote for five minutes by the clock. Attempt to confirm that what you're doing makes sense. \ No newline at end of file diff --git a/meta/vote-text-checklist.md b/meta/vote-text-checklist.md new file mode 100644 index 00000000..738a6e12 --- /dev/null +++ b/meta/vote-text-checklist.md @@ -0,0 +1,11 @@ + +# Rocket Pool Vote Text Checklist + +- [ ] Vote text should include the following: + - [ ] A short one-line summary intended to display effectively on the snapshot vote-listing page. + - [ ] Context as to the reason for the vote. + - [ ] A clear and concrete explanation of the possible outcomes of the voting process. + - [ ] Links to relevant resources or further context. + - [ ] A link to a relevant discussion thread on the Rocket Pool forums. +- [ ] The issue of framing bias has been considered and mitigated where possible. +- [ ] RPIP Editors have reviewed vote text. From 602782b8d9305e2ab27c82f0055cfca990216eba Mon Sep 17 00:00:00 2001 From: LongForWisdom Date: Thu, 5 Oct 2023 17:14:28 +0100 Subject: [PATCH 3/5] Added point to check URLs. --- meta/vote-text-checklist.md | 1 + 1 file changed, 1 insertion(+) diff --git a/meta/vote-text-checklist.md b/meta/vote-text-checklist.md index 738a6e12..d233a5ae 100644 --- a/meta/vote-text-checklist.md +++ b/meta/vote-text-checklist.md @@ -7,5 +7,6 @@ - [ ] A clear and concrete explanation of the possible outcomes of the voting process. - [ ] Links to relevant resources or further context. - [ ] A link to a relevant discussion thread on the Rocket Pool forums. +- [ ] Ensure that all URLs point to the intended destinations. - [ ] The issue of framing bias has been considered and mitigated where possible. - [ ] RPIP Editors have reviewed vote text. From ef8fa13fc6dcfddff9055994c01f0e476aa28dc5 Mon Sep 17 00:00:00 2001 From: LongForWisdom Date: Mon, 9 Oct 2023 14:05:12 +0100 Subject: [PATCH 4/5] Integrating feedback from prose11. --- meta/rpip-status-change-checklists.md | 1 + meta/vote-checklist.md | 3 ++- meta/vote-text-checklist.md | 4 +++- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/meta/rpip-status-change-checklists.md b/meta/rpip-status-change-checklists.md index bac41109..592c45cf 100644 --- a/meta/rpip-status-change-checklists.md +++ b/meta/rpip-status-change-checklists.md @@ -25,6 +25,7 @@ - [ ] Check that the ideas within the RPIP make technical sense. - [ ] Check that the RPIP title accurately describes the RPIP content. - [ ] Check the RPIP for language, markup, and code style. + - [ ] Run through grammarly or similar to help identify grammar and spelling issues. - [ ] Ensure that the RPIP author has confirmed the RPIP is ready to be finalized. - [ ] Ensure that the RPIP editors have confirmed the RPIP is ready to be finalized. diff --git a/meta/vote-checklist.md b/meta/vote-checklist.md index fe13ed32..4e0b8c2c 100644 --- a/meta/vote-checklist.md +++ b/meta/vote-checklist.md @@ -12,4 +12,5 @@ - Usually demonstrated by a poll on the RP forum that is open for at least 7 days. - [ ] Vote text has been completed for this vote. - [ ] The Vote Text checklist has been completed for the final iteration of the vote text. -- [ ] Think about this vote for five minutes by the clock. Attempt to confirm that what you're doing makes sense. \ No newline at end of file +- [ ] Think about this vote for five minutes by the clock. Attempt to confirm that what you're doing makes sense. +- [ ] Obtain confirmation from a relevant party of Rocket Pool Ltd that they intend to post the vote. \ No newline at end of file diff --git a/meta/vote-text-checklist.md b/meta/vote-text-checklist.md index d233a5ae..72fa7367 100644 --- a/meta/vote-text-checklist.md +++ b/meta/vote-text-checklist.md @@ -8,5 +8,7 @@ - [ ] Links to relevant resources or further context. - [ ] A link to a relevant discussion thread on the Rocket Pool forums. - [ ] Ensure that all URLs point to the intended destinations. -- [ ] The issue of framing bias has been considered and mitigated where possible. +- [ ] Ensure the vote text is presented in a neutral manner. + - [ ] The issue of framing bias has been considered and mitigated where possible. - [ ] RPIP Editors have reviewed vote text. +- [ ] Ensure a relevant representative of Rocket Pool Ltd has approved the vote text. \ No newline at end of file From 29a21ec7166f2f5c0561d422c1a293414b7db6b0 Mon Sep 17 00:00:00 2001 From: LongForWisdom Date: Wed, 25 Oct 2023 15:15:02 +0100 Subject: [PATCH 5/5] Reorder finalize checklist --- meta/rpip-status-change-checklists.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/rpip-status-change-checklists.md b/meta/rpip-status-change-checklists.md index 592c45cf..173fd7b3 100644 --- a/meta/rpip-status-change-checklists.md +++ b/meta/rpip-status-change-checklists.md @@ -16,10 +16,10 @@ - [ ] Ensure that the RPIP author is content with the draft being published on the RPIPs portal in its current state. ## Finalize Checklist +- [ ] Ensure that the finalization PR is the only open pull request modifying the RPIP in the official RPIP repository. - [ ] Ensure that the RPIP Draft Checklist has been completed for this RPIP. - [ ] Ensure that the RPIP preamble is present and correctly formatted for a finalized RPIP. - [ ] Check `status` is set to 'Final' -- [ ] Ensure that the finalization PR is the only open pull request modifying the RPIP in the official RPIP repository. - [ ] Editor Responsibilities - [ ] Check that the RPIP is ready, sound and complete. - [ ] Check that the ideas within the RPIP make technical sense.