Skip to content

Minor code cleanup questions #105

@MeanSquaredError

Description

@MeanSquaredError

While reading the new PR that adds NULLS FIRST/NULLS LAST, I came across a couple of places in the code that looked a slightly suspicious, so I decided to open a new issue about them:

  1. Comments about CRTP. There are several structures that have comments in them that they should be used in CRTP:
  1. There are a multiple places where various structures inherit from enable_comparison which means that they all get the asc() and desc() methods. E.g. type cast expressions, case expressions and string concat expressions inherit from enable_comparison. I haven't actually tried with an actual test program, but given that they all inherit from enable_comparison, it seems to me that they all get the asc() and desc() methods. Aren't there too many expressions that get these methods? E.g. all of the ones that I listed above shouldn't get asc() and desc().

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions