-
Notifications
You must be signed in to change notification settings - Fork 123
Open
Labels
triagedThis issue has been reviewed and triagedThis issue has been reviewed and triaged
Description
Summary
The hack/bicep-types-radius/src/generator package currently uses TypeScript 5.x. TypeScript 6.0 has been released but we are not yet ready to upgrade.
Why it's not done yet
TypeScript 6 introduces breaking changes to CJS/ESM module interop that affect our code:
- The default import of
yargsis resolved differently under TS 6, requiring a change fromyargstoyargs(process.argv.slice(2))insrc/cmd/generate.ts. - The
@typescript-eslint/*packages we depend on declarepeerDependenciesoftypescript: '>=4.8.4 <6.0.0', meaning TS 6 is outside their supported range. We need to wait for@typescript-eslintto release versions that support TS 6.
Current state
Dependabot has been configured to ignore the TypeScript 6.x major version bump (@dependabot ignore this major version for typescript) so it will not attempt to include this upgrade in grouped dependency PRs.
Action items
- Wait for
@typescript-eslint/eslint-pluginand@typescript-eslint/parserto support TypeScript 6 - Update
yargsusage insrc/cmd/generate.tsfromyargstoyargs(process.argv.slice(2))(or update yargs types) - Test
make generateend-to-end with TypeScript 6 - Remove the dependabot ignore rule for typescript once the upgrade is complete
References
- PR where this was discovered: Bump the npm-dependencies group across 3 directories with 17 updates #11515
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
triagedThis issue has been reviewed and triagedThis issue has been reviewed and triaged