From 922bcab4eafaad1c0c6dc887357cccb17de26bd8 Mon Sep 17 00:00:00 2001 From: "resyntax-ci[bot]" <181813515+resyntax-ci[bot]@users.noreply.github.com> Date: Sun, 3 Aug 2025 00:14:54 +0000 Subject: [PATCH 1/7] Fix 12 occurrences of `let-to-define` Internal definitions are recommended instead of `let` expressions, to reduce nesting. --- .../tests/drracket/syncheck-test.rkt | 21 ++- .../tests/drracket/teaching-lang-coverage.rkt | 79 +++++---- .../teaching-lang-sharing-modules.rkt | 21 +-- drracket-test/tests/drracket/teachpack.rkt | 155 ++++++++---------- .../tests/drracket/test-engine-test.rkt | 32 ++-- 5 files changed, 145 insertions(+), 163 deletions(-) diff --git a/drracket-test/tests/drracket/syncheck-test.rkt b/drracket-test/tests/drracket/syncheck-test.rkt index 884a25a79..b2bd73bea 100644 --- a/drracket-test/tests/drracket/syncheck-test.rkt +++ b/drracket-test/tests/drracket/syncheck-test.rkt @@ -2069,15 +2069,18 @@ (for-each (test-binding #f actual-ht) (hash-map expected-ht cons)))) (define (compare-output raw-expected got arrows arrows-got input line) - (let ([expected (collapse-and-rename raw-expected)]) - (cond - [(not-matching-colors got expected) - => - (λ (msg) - (eprintf "FAILED line ~a: ~s\n expected: ~s\n got: ~s\n ~a\n" - line input expected got msg))] - [else - (compare-arrows input arrows arrows-got line)]))) + (define expected (collapse-and-rename raw-expected)) + (cond + [(not-matching-colors got expected) + => + (λ (msg) + (eprintf "FAILED line ~a: ~s\n expected: ~s\n got: ~s\n ~a\n" + line + input + expected + got + msg))] + [else (compare-arrows input arrows arrows-got line)])) (define (not-matching-colors got expected) (let loop ([got got] diff --git a/drracket-test/tests/drracket/teaching-lang-coverage.rkt b/drracket-test/tests/drracket/teaching-lang-coverage.rkt index 6977d70af..c60707b9b 100644 --- a/drracket-test/tests/drracket/teaching-lang-coverage.rkt +++ b/drracket-test/tests/drracket/teaching-lang-coverage.rkt @@ -67,17 +67,15 @@ ;; get-annotate-output : drscheme-frame -> (listof str/ann) (define (get-annotated-output drs) - (let ([chan (make-channel)]) - (queue-callback - (λ () - (channel-put chan (get-string/style-desc (send drs get-definitions-text))))) - (channel-get chan))) + (define chan (make-channel)) + (queue-callback (λ () (channel-put chan (get-string/style-desc (send drs get-definitions-text))))) + (channel-get chan)) ;; returns #t if an element of the result of get-string/style-desc ;; corresponds to an uncovered region of the editor (define (is-uncovered? ele) - (let ([style (list-ref ele 1)]) - (eq? style 'test-coverage-off))) + (define style (list-ref ele 1)) + (eq? style 'test-coverage-off)) ;; find-uncovered-text : list[get-string/style-desc result] -> (listof string) ;; returns strings containing the uncovered text in the editor (in the order they appear in the file) @@ -86,38 +84,35 @@ (fire-up-drracket-and-run-tests (λ () - (let* ([drr-frame (wait-for-drracket-frame)] - [definitions-text (send drr-frame get-definitions-text)] - [interactions-text (send drr-frame get-interactions-text)]) - - (let ([last-lang #f]) - (for ([t (in-list tests)]) - - - (let* ([this-lang (test-lang-regexp t)] - [same-last-time? (and (regexp? last-lang) - (equal? (object-name last-lang) - (object-name this-lang)))]) - (unless same-last-time? - (set! last-lang this-lang) - (set-language-level! (list this-lang)))) - - (clear-definitions drr-frame) - (insert-in-definitions drr-frame (test-program t)) - (do-execute drr-frame) - - (let ([result (fetch-output - drr-frame - (send interactions-text paragraph-start-position 2) - (send interactions-text last-position))]) - (unless (regexp-match #rx"^[ \n\t0-9>]*$" result) - (eprintf "FAILED line ~a, got ~s for the output, but expected only digits and whitespace" - (test-line t) - result))) - - (let ([got (find-uncovered-text (get-annotated-output drr-frame))]) - (unless (equal? got (test-uncovered t)) - (eprintf "FAILED line ~a\n got: ~s\nexpected: ~s\n" - (test-line t) - got - (test-uncovered t))))))))) + (define drr-frame (wait-for-drracket-frame)) + (send drr-frame get-definitions-text) + (define interactions-text (send drr-frame get-interactions-text)) + + (define last-lang #f) + (for ([t (in-list tests)]) + + (let* ([this-lang (test-lang-regexp t)] + [same-last-time? (and (regexp? last-lang) + (equal? (object-name last-lang) (object-name this-lang)))]) + (unless same-last-time? + (set! last-lang this-lang) + (set-language-level! (list this-lang)))) + + (clear-definitions drr-frame) + (insert-in-definitions drr-frame (test-program t)) + (do-execute drr-frame) + + (let ([result (fetch-output drr-frame + (send interactions-text paragraph-start-position 2) + (send interactions-text last-position))]) + (unless (regexp-match #rx"^[ \n\t0-9>]*$" result) + (eprintf "FAILED line ~a, got ~s for the output, but expected only digits and whitespace" + (test-line t) + result))) + + (let ([got (find-uncovered-text (get-annotated-output drr-frame))]) + (unless (equal? got (test-uncovered t)) + (eprintf "FAILED line ~a\n got: ~s\nexpected: ~s\n" + (test-line t) + got + (test-uncovered t))))))) diff --git a/drracket-test/tests/drracket/teaching-lang-sharing-modules.rkt b/drracket-test/tests/drracket/teaching-lang-sharing-modules.rkt index 620314ba9..7aa5cf4c5 100644 --- a/drracket-test/tests/drracket/teaching-lang-sharing-modules.rkt +++ b/drracket-test/tests/drracket/teaching-lang-sharing-modules.rkt @@ -42,22 +42,19 @@ Of course, other (similar) things can go wrong, too. (for ([exp (in-list things-to-try)]) (insert-in-definitions drs-frame (format "~s\n" exp))) (do-execute drs-frame) - (let ([output (fetch-output drs-frame)]) - (cond - [(equal? output first-line-output) - (try-interaction-test drs-frame)] - [else - (eprintf "teaching-lang-sharing-modules.rkt: got bad output from execute: ~s" - output)]))) + (define output (fetch-output drs-frame)) + (cond + [(equal? output first-line-output) (try-interaction-test drs-frame)] + [else (eprintf "teaching-lang-sharing-modules.rkt: got bad output from execute: ~s" output)])) #:prefs '([plt:framework-pref:framework:autosaving-on? #f]))) (define (try-interaction-test drs-frame) (type-in-interactions drs-frame "1\n") (wait-for-computation drs-frame) - (let ([interactions-output (fetch-output drs-frame)]) - (unless (equal? interactions-output (format "~a\n> 1\n1" first-line-output)) - (error 'teaching-language-sharing-modules.rkt - "got bad output from interaction: ~s\n" - interactions-output)))) + (define interactions-output (fetch-output drs-frame)) + (unless (equal? interactions-output (format "~a\n> 1\n1" first-line-output)) + (error 'teaching-language-sharing-modules.rkt + "got bad output from interaction: ~s\n" + interactions-output))) (go) diff --git a/drracket-test/tests/drracket/teachpack.rkt b/drracket-test/tests/drracket/teachpack.rkt index a85d19427..391eed52a 100644 --- a/drracket-test/tests/drracket/teachpack.rkt +++ b/drracket-test/tests/drracket/teachpack.rkt @@ -44,95 +44,78 @@ (do-execute drs-frame) - (let ([got (fetch-output drs-frame)] - [full-expectation - (string-append - (apply string-append (map (lambda (x) (format "Teachpack: ~a.\n" x)) tp-names)) - expected - "\nThis psorgram should be tested.")]) - (unless (equal? got - full-expectation) - (eprintf - "FAILED: tp: ~s\n exp: ~s\n expected: ~s\n got: ~s\n" - tp-exps - dr-exp - full-expectation - got))))) + (define got (fetch-output drs-frame)) + (define full-expectation + (string-append (apply string-append (map (lambda (x) (format "Teachpack: ~a.\n" x)) tp-names)) + expected + "\nThis psorgram should be tested.")) + (unless (equal? got full-expectation) + (eprintf + "FAILED: tp: ~s\n exp: ~s\n expected: ~s\n got: ~s\n" + tp-exps + dr-exp + full-expectation + got)))) ;; there are no more errors when the teachpack is loaded (for now...) (define (test-bad/load-teachpack tp-exp expected-error) (fw:test:menu-select "Language" "Clear All Teachpacks") - (let ([tp-name (normal-case-path - (normalize-path - (build-path - (collection-path "tests" "drracket") - "teachpack-tmp.ss")))]) - (call-with-output-file tp-name - (lambda (port) (display tp-exp port)) - 'truncate) - (use-get/put-dialog - (lambda () - (fw:test:menu-select "Language" "Add Teachpack…")) - tp-name) - (let ([dialog - (with-handlers ([(lambda (x) #t) - (lambda (x) #f)]) - (wait-for-new-frame drs-frame))]) - (cond - [dialog - (let ([got (send dialog get-message)]) - (unless (string=? got expected-error) - (eprintf "FAILED: tp: ~s\n expected: ~s\n got: ~s\n" - tp-exp expected-error got)) - (fw:test:button-push "Ok") - (wait-for-new-frame dialog))] - [else - (eprintf "FAILED: no error message appeared\n tp: ~s\n expected: ~s\n" - tp-exp expected-error)])))) + (define tp-name + (normal-case-path (normalize-path (build-path (collection-path "tests" "drracket") + "teachpack-tmp.ss")))) + (call-with-output-file tp-name (lambda (port) (display tp-exp port)) 'truncate) + (use-get/put-dialog (lambda () (fw:test:menu-select "Language" "Add Teachpack…")) tp-name) + (let ([dialog (with-handlers ([(lambda (x) #t) (lambda (x) #f)]) + (wait-for-new-frame drs-frame))]) + (cond + [dialog + (let ([got (send dialog get-message)]) + (unless (string=? got expected-error) + (eprintf "FAILED: tp: ~s\n expected: ~s\n got: ~s\n" + tp-exp + expected-error + got)) + (fw:test:button-push "Ok") + (wait-for-new-frame dialog))] + [else + (eprintf "FAILED: no error message appeared\n tp: ~s\n expected: ~s\n" + tp-exp + expected-error)]))) (define (test-bad/execute-teachpack tp-exp expected) (fw:test:menu-select "Language" "Clear All Teachpacks") - (let ([tp-name (normal-case-path - (normalize-path - (build-path - (collection-path "tests" "drracket") - "teachpack-tmp.ss")))]) - (call-with-output-file tp-name - (lambda (port) (display tp-exp port)) - 'truncate) - (use-get/put-dialog - (lambda () - (fw:test:menu-select "Language" "Add Teachpack…")) - tp-name) - (do-execute drs-frame #f) - (let ([dialog - (with-handlers ([exn:fail? (lambda (x) #f)]) - (let ([wait-for-error-pred - (lambda () - (let ([active - (or - (test:get-active-top-level-window) - (and (send interactions-text get-user-eventspace) - (parameterize ([current-eventspace - (send interactions-text get-user-eventspace)]) - (test:get-active-top-level-window))))]) - (if (and active (not (eq? active drs-frame))) - active - #f)))]) - (poll-until wait-for-error-pred)))]) - (cond - [dialog - (let ([got (send dialog get-message)] - [expected-error - (format "Invalid Teachpack: ~a\n~a" tp-name expected)]) - (unless (string=? got expected-error) - (eprintf "FAILED: tp: ~s\n expected: ~s\n got: ~s\n" - tp-exp expected-error got)) - (fw:test:button-push "Ok") - (wait-for-new-frame dialog))] - [else - (eprintf "FAILED: no error message appeared\n tp: ~s\n expected: ~s\n" - tp-exp error)])))) + (define tp-name + (normal-case-path (normalize-path (build-path (collection-path "tests" "drracket") + "teachpack-tmp.ss")))) + (call-with-output-file tp-name (lambda (port) (display tp-exp port)) 'truncate) + (use-get/put-dialog (lambda () (fw:test:menu-select "Language" "Add Teachpack…")) tp-name) + (do-execute drs-frame #f) + (define dialog + (with-handlers ([exn:fail? (lambda (x) #f)]) + (let ([wait-for-error-pred + (lambda () + (let ([active (or (test:get-active-top-level-window) + (and (send interactions-text get-user-eventspace) + (parameterize ([current-eventspace (send interactions-text + get-user-eventspace)]) + (test:get-active-top-level-window))))]) + (if (and active (not (eq? active drs-frame))) active #f)))]) + (poll-until wait-for-error-pred)))) + (cond + [dialog + (let ([got (send dialog get-message)] + [expected-error (format "Invalid Teachpack: ~a\n~a" tp-name expected)]) + (unless (string=? got expected-error) + (eprintf "FAILED: tp: ~s\n expected: ~s\n got: ~s\n" + tp-exp + expected-error + got)) + (fw:test:button-push "Ok") + (wait-for-new-frame dialog))] + [else + (eprintf "FAILED: no error message appeared\n tp: ~s\n expected: ~s\n" + tp-exp + error)])) (define (generic-tests) (test-good-teachpack @@ -179,10 +162,10 @@ (lambda (port) (apply string-append (let loop () - (let ([l (read-line port)]) - (if (eof-object? l) - null - (list* l " " (loop))))))) + (define l (read-line port)) + (if (eof-object? l) + null + (list* l " " (loop)))))) 'text)) ;; doesn't test graphing.ss teachpack diff --git a/drracket-test/tests/drracket/test-engine-test.rkt b/drracket-test/tests/drracket/test-engine-test.rkt index 79753ef97..a3dda568f 100644 --- a/drracket-test/tests/drracket/test-engine-test.rkt +++ b/drracket-test/tests/drracket/test-engine-test.rkt @@ -243,11 +243,11 @@ (common-signatures-sdp))) (define (prepare-for-test-expression) - (let ([drs (wait-for-drracket-frame)]) - (clear-definitions drs) - (set-language #t) - (sleep 1) ;; this shouldn't be neccessary.... - (do-execute drs))) + (define drs (wait-for-drracket-frame)) + (clear-definitions drs) + (set-language #t) + (sleep 1) ;; this shouldn't be neccessary.... + (do-execute drs)) ;; test-setting : (-> void) string string string -> void ;; opens the language dialog, runs `set-setting' @@ -262,15 +262,19 @@ (let ([f (test:get-active-top-level-window)]) (fw:test:button-push "OK") (wait-for-new-frame f)) - (let* ([drs (test:get-active-top-level-window)] - [interactions (send drs get-interactions-text)]) - (clear-definitions drs) - (insert-in-definitions drs expression) - (do-execute drs) - (let ([got (fetch-output/should-be-tested drs)]) - (unless (string=? result got) - (eprintf "FAILED: ~s ~s ~s test\n expected: ~s\n got: ~s\n" - (language) setting-name expression result got))))) + (define drs (test:get-active-top-level-window)) + (send drs get-interactions-text) + (clear-definitions drs) + (insert-in-definitions drs expression) + (do-execute drs) + (define got (fetch-output/should-be-tested drs)) + (unless (string=? result got) + (eprintf "FAILED: ~s ~s ~s test\n expected: ~s\n got: ~s\n" + (language) + setting-name + expression + result + got))) (define (fetch-output/should-be-tested . args) (regexp-replace (regexp From 24d812f4567e7e03a4f8ccabece790841d0f4ee0 Mon Sep 17 00:00:00 2001 From: "resyntax-ci[bot]" <181813515+resyntax-ci[bot]@users.noreply.github.com> Date: Sun, 3 Aug 2025 00:14:54 +0000 Subject: [PATCH 2/7] Fix 1 occurrence of `nested-when-to-compound-when` Nested `when` expressions can be merged into a single compound `when` expression. --- .../tests/drracket/no-write-and-frame-leak.rkt | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drracket-test/tests/drracket/no-write-and-frame-leak.rkt b/drracket-test/tests/drracket/no-write-and-frame-leak.rkt index 167235d81..192e23b60 100644 --- a/drracket-test/tests/drracket/no-write-and-frame-leak.rkt +++ b/drracket-test/tests/drracket/no-write-and-frame-leak.rkt @@ -139,13 +139,11 @@ This test checks: (process-container item))))) (define (record-shortcut item) - (when (is-a? item selectable-menu-item<%>) - (when (send item get-shortcut) - (define k (append (sort (send item get-shortcut-prefix) - string<=? - #:key symbol->string) - (list (send item get-shortcut)))) - (hash-update! shortcuts k (λ (v) (cons (send item get-label) v)) '())))) + (when (and (is-a? item selectable-menu-item<%>) (send item get-shortcut)) + (define k + (append (sort (send item get-shortcut-prefix) string<=? #:key symbol->string) + (list (send item get-shortcut)))) + (hash-update! shortcuts k (λ (v) (cons (send item get-label) v)) '()))) (define (get-lab item) (cond From 93d44492d6d004c943853039b2272840c87aa316 Mon Sep 17 00:00:00 2001 From: "resyntax-ci[bot]" <181813515+resyntax-ci[bot]@users.noreply.github.com> Date: Sun, 3 Aug 2025 00:14:54 +0000 Subject: [PATCH 3/7] Fix 1 occurrence of `inline-unnecessary-begin` This `begin` form can be flattened into the surrounding definition context. --- drracket-test/tests/drracket/syncheck-test.rkt | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drracket-test/tests/drracket/syncheck-test.rkt b/drracket-test/tests/drracket/syncheck-test.rkt index b2bd73bea..e3ae322e8 100644 --- a/drracket-test/tests/drracket/syncheck-test.rkt +++ b/drracket-test/tests/drracket/syncheck-test.rkt @@ -1772,12 +1772,11 @@ (λ () (define drs (wait-for-drracket-frame)) ;(set-language-level! (list "Pretty Big")) - (begin - (set-language-level! (list "Pretty Big") #f) - (test:set-radio-box-item! "No debugging or profiling") - (let ([f (test:get-active-top-level-window)]) - (test:button-push "OK") - (wait-for-new-frame f))) + (set-language-level! (list "Pretty Big") #f) + (test:set-radio-box-item! "No debugging or profiling") + (let ([f (test:get-active-top-level-window)]) + (test:button-push "OK") + (wait-for-new-frame f)) (do-execute drs) (define defs (queue-callback/res (λ () (send drs get-definitions-text)))) (define filename (make-temporary-file "syncheck-test~a" #f temp-dir)) From b93ee6e4661630f27a2edff26c441b9f21e6aa66 Mon Sep 17 00:00:00 2001 From: "resyntax-ci[bot]" <181813515+resyntax-ci[bot]@users.noreply.github.com> Date: Sun, 3 Aug 2025 00:14:54 +0000 Subject: [PATCH 4/7] Fix 1 occurrence of `map-to-for` This `map` operation can be replaced with a `for/list` loop. --- drracket-test/tests/drracket/syncheck-test.rkt | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drracket-test/tests/drracket/syncheck-test.rkt b/drracket-test/tests/drracket/syncheck-test.rkt index e3ae322e8..ee6a1856d 100644 --- a/drracket-test/tests/drracket/syncheck-test.rkt +++ b/drracket-test/tests/drracket/syncheck-test.rkt @@ -1997,14 +1997,13 @@ (define (collapse-and-rename expected) (define renamed - (map (lambda (ent) - (let* ([str (car ent)] - [id (cadr ent)] - [matches (assoc id remappings)]) - (if matches - (list str (cadr matches)) - ent))) - expected)) + (for/list ([ent (in-list expected)]) + (define str (car ent)) + (define id (cadr ent)) + (define matches (assoc id remappings)) + (if matches + (list str (cadr matches)) + ent))) (let loop ([ids renamed]) (cond [(null? ids) null] From 1e99db9826122167a564ad20e4d196d41f6892df Mon Sep 17 00:00:00 2001 From: "resyntax-ci[bot]" <181813515+resyntax-ci[bot]@users.noreply.github.com> Date: Sun, 3 Aug 2025 00:14:54 +0000 Subject: [PATCH 5/7] Fix 2 occurrences of `cond-let-to-cond-define` Internal definitions are recommended instead of `let` expressions, to reduce nesting. --- .../tests/drracket/syncheck-test.rkt | 10 +++---- drracket-test/tests/drracket/teachpack.rkt | 26 +++++++------------ 2 files changed, 15 insertions(+), 21 deletions(-) diff --git a/drracket-test/tests/drracket/syncheck-test.rkt b/drracket-test/tests/drracket/syncheck-test.rkt index ee6a1856d..7a5511ae2 100644 --- a/drracket-test/tests/drracket/syncheck-test.rkt +++ b/drracket-test/tests/drracket/syncheck-test.rkt @@ -2009,11 +2009,11 @@ [(null? ids) null] [(null? (cdr ids)) ids] [else - (let ([fst (car ids)] - [snd (cadr ids)]) - (if (eq? (cadr fst) (cadr snd)) - (loop (cons (list (string-append (car fst) (car snd)) (cadr fst)) (cddr ids))) - (cons fst (loop (cdr ids)))))]))) + (define fst (car ids)) + (define snd (cadr ids)) + (if (eq? (cadr fst) (cadr snd)) + (loop (cons (list (string-append (car fst) (car snd)) (cadr fst)) (cddr ids))) + (cons fst (loop (cdr ids))))]))) ;; compare-arrows : expression ;; (or/c #f (listof (cons (list number-or-proc number-or-proc) diff --git a/drracket-test/tests/drracket/teachpack.rkt b/drracket-test/tests/drracket/teachpack.rkt index 391eed52a..71cfd9a13 100644 --- a/drracket-test/tests/drracket/teachpack.rkt +++ b/drracket-test/tests/drracket/teachpack.rkt @@ -25,22 +25,16 @@ (cond [(null? tp-exps) null] [else - (let ([tp-name - (normal-case-path - (normalize-path - (collection-file-path - (string-append - (format good-teachpack-name n) - ".ss") - "tests" "drracket")))]) - (call-with-output-file tp-name - (lambda (port) (write (car tp-exps) port)) - 'truncate) - (use-get/put-dialog - (lambda () - (fw:test:menu-select "Language" "Add Teachpack…")) - tp-name) - (cons tp-name (loop (cdr tp-exps) (+ n 1))))]))]) + (define tp-name + (normal-case-path (normalize-path (collection-file-path + (string-append (format good-teachpack-name n) + ".ss") + "tests" + "drracket")))) + (call-with-output-file tp-name (lambda (port) (write (car tp-exps) port)) 'truncate) + (use-get/put-dialog (lambda () (fw:test:menu-select "Language" "Add Teachpack…")) + tp-name) + (cons tp-name (loop (cdr tp-exps) (+ n 1)))]))]) (do-execute drs-frame) From aa2053020a9a181d8c7f16591d3730e835714276 Mon Sep 17 00:00:00 2001 From: "resyntax-ci[bot]" <181813515+resyntax-ci[bot]@users.noreply.github.com> Date: Sun, 3 Aug 2025 00:14:54 +0000 Subject: [PATCH 6/7] Fix 2 occurrences of `string-append-with-format-to-format` This `string-append` with `format` expression can be simplified to a single `format` call. --- drracket-test/tests/drracket/language-test.rkt | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drracket-test/tests/drracket/language-test.rkt b/drracket-test/tests/drracket/language-test.rkt index 4c2942a09..32a448f90 100644 --- a/drracket-test/tests/drracket/language-test.rkt +++ b/drracket-test/tests/drracket/language-test.rkt @@ -1933,16 +1933,22 @@ the settings above should match r5rs (define (test-undefined-var id #:icon+in? [icon+in? #f]) (test-expression id - (string-append (if icon+in? "{stop-22x22.png} " "") - (format "~a: this variable is not defined" id) - (if icon+in? (format " in: ~a " id) "")))) + (format "~a~a: this variable is not defined~a" + (if icon+in? "{stop-22x22.png} " "") + id + (if icon+in? + (format " in: ~a " id) + "")))) (define (test-undefined-fn exp id #:icon+in? [icon+in? #f]) (test-expression exp - (string-append (if icon+in? "{stop-22x22.png} " "") - (format "~a: this function is not defined" id) - (if icon+in? (format " in: ~a " id) "")))) + (format "~a~a: this function is not defined~a" + (if icon+in? "{stop-22x22.png} " "") + id + (if icon+in? + (format " in: ~a " id) + "")))) (define-syntax (go stx) (syntax-case stx () From c92473e442b482f7a6c06980d25d73ceafaa9d19 Mon Sep 17 00:00:00 2001 From: "resyntax-ci[bot]" <181813515+resyntax-ci[bot]@users.noreply.github.com> Date: Sun, 3 Aug 2025 00:14:54 +0000 Subject: [PATCH 7/7] Fix 1 occurrence of `make-temporary-directory-migration` Use `make-temporary-directory` to make directories instead of `make-temporary-file`. --- drracket-test/tests/drracket/example-tool.rkt | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drracket-test/tests/drracket/example-tool.rkt b/drracket-test/tests/drracket/example-tool.rkt index a2ba53506..316c2874b 100644 --- a/drracket-test/tests/drracket/example-tool.rkt +++ b/drracket-test/tests/drracket/example-tool.rkt @@ -8,8 +8,7 @@ (define new-collection-root #; (string->path "C:\\tmp") - (make-temporary-file "drracket-test-example-tool~a" - 'directory)) + (make-temporary-directory "drracket-test-example-tool~a")) (define coll (build-path new-collection-root "coll")) (unless (directory-exists? coll) (make-directory coll))