Skip to content

archive/Dockerfile used to build visor images #18

@vistrcm

Description

@vistrcm

Summary of Bug

Hello,
It looks like archive/Dockerfile used to build cosmovisor images instead of visor/Dockerfile.
GithubActions configured to use docker/node/archive/Dockerfile for both archive and visor images.

Archive: https://github.com/provenance-io/testnet/blob/main/.github/workflows/docker.yml#L41
cosmovisor: https://github.com/provenance-io/testnet/blob/main/.github/workflows/docker.yml#L49

Because of that changes like 08304a7 have no effect.

Possible fix: #19

Version

GitHash c1dc285

Steps to Reproduce

Visor Docker image build in https://github.com/provenance-io/testnet/runs/2546680132?check_suite_focus=true#step:7:76
sha: 71dd4c9759f9eb776ff59b90a7c3753191c276b18e394a1620702213041042fe
do not include visor changes for docker-entrypoint.sh

docker run -it provenanceio/node@sha256:71dd4c9759f9eb776ff59b90a7c3753191c276b18e394a1620702213041042fe cat /docker-entrypoint.sh
#!/usr/bin/env bash

# No config dir yet, create it.
if [ ! -d "${PIO_HOME}/config" ]; then
  mkdir -p "${PIO_HOME}/config"
fi

# No data dir yet, create it
if [ ! -d "${PIO_HOME}/data" ]; then
    mkdir "${PIO_HOME}/data"
fi

# If custom genesis.json is not provided, use the default.
if [ ! -f "${PIO_HOME}/config/genesis.json" ]; then
  cp "/${CHAIN_ID}/genesis.json" "${PIO_HOME}/config/genesis.json"
fi

# If custom config.toml is not provided, use the default.
if [ ! -f "${PIO_HOME}/config/config.toml" ]; then
  cp "/${CHAIN_ID}/node-config.toml" "${PIO_HOME}/config/config.toml"
fi

# If custom app.toml is not provided, use the default.
if [ ! -f "${PIO_HOME}/config/app.toml" ]; then
  cp "/${CHAIN_ID}/node-app.toml" "${PIO_HOME}/config/app.toml"
fi

exec "$@"

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions