Move gcovr options to config file#21663
Merged
iluuu1994 merged 1 commit intophp:masterfrom Apr 7, 2026
Merged
Conversation
Having these in the make file is very annoying, because it requires rebuilding from scratch and rerunning tests just to see if some flag is effective.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21663 +/- ##
=======================================
Coverage 70.77% 70.77%
=======================================
Files 812 812
Lines 296976 296976
Branches 84534 84534
=======================================
Hits 210199 210199
+ Misses 56610 56608 -2
- Partials 30167 30169 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having these in the make file is very annoying, because it requires rebuilding from scratch and rerunning tests just to see if some flag is effective.
Note: gcovr config files are marked as experiemental:
https://gcovr.com/en/latest/guide/configuration.html
However, they've been experimental for ~4 years and it's unlikely it'll go anywhere. Even if, we use this for internal purposes only.