Skip to content

Fix SKIPIF of openssl_password.phpt#20941

Merged
ndossche merged 1 commit intophp:PHP-8.4from
ndossche:ossl-test-fix
Apr 3, 2026
Merged

Fix SKIPIF of openssl_password.phpt#20941
ndossche merged 1 commit intophp:PHP-8.4from
ndossche:ossl-test-fix

Conversation

@ndossche
Copy link
Copy Markdown
Member

@ndossche ndossche commented Jan 14, 2026

It's possible there is no argon2 provider at all.

@ndossche
Fix SKIPIF of openssl_password.phpt
1de9599 
It's possible there is no argon2 provider at all.
@ndossche ndossche requested a review from bukka as a code owner January 14, 2026 22:33
@bukka
Copy link
Copy Markdown
Member

bukka commented Apr 3, 2026

I'm not sure I understand this. In what configuration this doesn't work?

@ndossche
Copy link
Copy Markdown
Member Author

ndossche commented Apr 3, 2026

If HAVE_OPENSSL_ARGON2 is off and libargon2 is not available (for ext/standard) and libsodium is not available.

@ndossche ndossche merged commit 1c94632 into php:PHP-8.4 Apr 3, 2026
10 checks passed
ndossche added a commit that referenced this pull request Apr 3, 2026
@ndossche
Merge branch 'PHP-8.4' into PHP-8.5
4d544e4 
* PHP-8.4:
  openssl: Fix error propagation in csr exports (#21403)
  openssl: Fix missing error propagation in openssl_x509_export() (#21375)
  Fix SKIPIF of openssl_password.phpt (#20941)
ndossche added a commit that referenced this pull request Apr 3, 2026
@ndossche
Merge branch 'PHP-8.5'
a0e679e 
* PHP-8.5:
  openssl: Fix error propagation in csr exports (#21403)
  openssl: Fix missing error propagation in openssl_x509_export() (#21375)
  Fix SKIPIF of openssl_password.phpt (#20941)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bukka bukka bukka approved these changes

Assignees

No one assigned

Labels

Extension: openssl

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ndossche @bukka @iluuu1994