Check unchecked error-prone calls in ext/ssl#19659
Open
alexandre-daubois wants to merge 2 commits intophp:PHP-8.4from
Open
Check unchecked error-prone calls in ext/ssl#19659alexandre-daubois wants to merge 2 commits intophp:PHP-8.4from
alexandre-daubois wants to merge 2 commits intophp:PHP-8.4from
Conversation
alexandre-daubois
force-pushed
the
ssl-errors
branch
2 times, most recently
from
e7727ad to
ad1f4e1
Compare
Member
Author
|
Friendly ping @ndossche as you're the author of the issue |
bukka
reviewed
Mar 27, 2026
bukka
reviewed
Mar 27, 2026
bukka
reviewed
Mar 27, 2026
alexandre-daubois
force-pushed
the
ssl-errors
branch
from
7295ccd to
0c56417
Compare
alexandre-daubois
force-pushed
the
ssl-errors
branch
from
0c56417 to
096d7b8
Compare
Member
Author
|
Thanks Jakub, I addressed your comments |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #18988
Some calls are not findable, or their errors are deliberately ignored (for example
NCONF_get_number).