Skip to content

[Bug] Increasing column width fails with Foot terminal #159

@ptousig1

Description

@ptousig1

Karousel version: 0.15
Plasma version: 6.6.0
X11 / Wayland: Wayland

Description: When using the Foot terminal, the karousel-column-width-increase action does (almost) nothing.
After some debugging, I found that RawResizer.increaseWidth was calling column.setWidth with one value, but on the next call the value returned by column.getWidth() was slightly less.

I'm guessing this is because Foot is resizing itself to match its character grid. One clue is that if you smash the column increase keybinding fast enough, the window will eventually increase. Probably because Foot didn't have time to shrink the window yet.

I don't know what the proper fix would be, but my temporary fix is to subtract 10 to the widths, like so:
const newWidth = findMinPositive( [ ...this.presetWidths.getWidths(column.getMinWidth(), column.getMaxWidth()), ], width => width - column.getWidth() - 10, );

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions