Failed to make unique variant names for [=,>,<,≥,>=,≤,<=,≠,!=]

[mickvangelderen]

$ cargo typify ./factorio-data-raw-json-schema.full.json
The application panicked (crashed).
Message:  Failed to make unique variant names for [=,>,<,≥,>=,≤,<=,≠,!=]
Location: C:\Users\runneradmin\.cargo\registry\src\index.crates.io-1949cf8c6b5b557f\typify-impl-0.5.0\src\type_entry.rs:286

Schema: https://raw.githubusercontent.com/jacquev6/factorio-data-raw-json-schema/5bf7e246ce839017ee03f0f5ecb264b3b31a0b95/factorio-data-raw-json-schema.full.json.

Offending definition:

    "ComparatorString": {
      "description": "https://lua-api.factorio.com/stable/types/ComparatorString.html",
      "anyOf": [
        {
          "type": "string",
          "const": "="
        },
        {
          "type": "string",
          "const": ">"
        },
        {
          "type": "string",
          "const": "<"
        },
        {
          "type": "string",
          "const": "\u2265"
        },
        {
          "type": "string",
          "const": ">="
        },
        {
          "type": "string",
          "const": "\u2264"
        },
        {
          "type": "string",
          "const": "<="
        },
        {
          "type": "string",
          "const": "\u2260"
        },
        {
          "type": "string",
          "const": "!="
        }
      ]
    },

EDIT: Seems like this is the same issue as #749

[mickvangelderen]

Providing these replacements manually does the trick, at least when it comes that part:

// If every case was special then none of them would be.
let out = match input {
    "async" => "async_".to_string(), // TODO syn should handle this case...
    "+1" => "plus1".to_string(),
    "-1" => "minus1".to_string(),
    "=" => to_case("equal"),
    ">" => to_case("greater_than"),
    "<" => to_case("less_than"),
    "≥" => to_case("greater_than_or_equal_unicode"),
    ">=" => to_case("greater_than_or_equal"),
    "≤" => to_case("less_than_or_equal_unicode"),
    "<=" => to_case("less_than_or_equal"),
    "≠" => to_case("not_equal_unicode"),
    "!=" => to_case("not_equal"),
    _ => to_case(&input.replace("'", "").replace(|c| !is_xid_continue(c), "-")),
};

The process is slow and runs oom:

$ cargo run --bin cargo-typify --release -- typify -- C:\\Users\\mick\\projects\\factorio-calculations\\factorio-data-raw-json-schema.full.json
    Finished `release` profile [optimized] target(s) in 0.18s
     Running `target\release\cargo-typify.exe typify -- 'C:\Users\mick\projects\factorio-calculations\factorio-data-raw-json-schema.full.json'`
memory allocation of 1073741824 bytes failed
error: process didn't exit successfully: `target\release\cargo-typify.exe typify -- 'C:\Users\mick\projects\factorio-calculations\factorio-data-raw-json-schema.full.json'` (exit code: 0xc0000409, STATUS_STACK_BUFFER_OVERRUN)

Does json schema provide a way to annotate these oneOf members giving them a name? Besides that, accepting some sort of manual renaming mapping to go along with the schema could be practical, although that mapping would be keyed on const values and that seems rather specific.

Not sure why the type definition doesn't just use enum instead of the `oneOf``

{
  "type": "string",
  "enum": ["=", ">", "<", "≥", ">=", "≤", "<=", "≠", "!="]
}

[ahl]

This is a neat one; thanks for filing it. There are a couple of failures here.

First, yes, we don't provide a mechanism for injecting names and JSON schema doesn't have anything built in.

I believe the reason we're running out of memory is that with the anyOf (note: it's not a oneOf) we try calculate the powerset and then eliminate conflicts. You might try changing this to a oneOf. Good point about the enum being a much better way to express this.

The best near-term workaround is to create a enum by hand and use the replace or convert mechanisms to replace the type by name or by structure with a hand-written type. We're working on a more significant update that will permit you to annotate schemas with names you'd like used for variants.

[ndreno]

We've implemented a fix for this in our fork at barbacane-dev/typify. Happy to extract a clean PR if there's interest.