Types with explicit defaults on required fields do not implement Default

[jasperswallen]

MRE:

Schema:

{
  "definitions": {
    "Field": {
      "type": "object",
      "properties": {
        "addr": {
          "type": "string",
          "default": "default_string"
        }
      },
      "required": [
        "addr"
      ]
    }
  }
}

Generates:

#[derive(:: serde :: Deserialize, :: serde :: Serialize, Clone, Debug)]
pub struct Field {
    pub addr: ::std::string::String,
}
impl ::std::convert::From<&Field> for Field {
    fn from(value: &Field) -> Self {
        value.clone()
    }
}

However, there should be another impl on Field:

impl Default for Field {
    fn default() -> Self {
        Self {
            addr: "default_string".to_string(),
        }
    }
}

[ahl]

Agreed. FWIW, we don't even pick up that default for the builder:

pub mod builder {
    #[derive(Clone, Debug)]
    pub struct Field {
        addr: ::std::result::Result<::std::string::String, ::std::string::String>,
    }
    impl ::std::default::Default for Field {
        fn default() -> Self {
            Self {
                addr: Err("no value supplied for addr".to_string()),
            }
        }
    }
    // ...

I would have expected addr: Ok("default_string".to_string()),

[ndreno]

We've implemented a fix for this in our fork at barbacane-dev/typify. Happy to extract a clean PR if there's interest.