`SagaDagIterator` could/should implement `ExactSizeIterator`

[smklein]

Context: oxidecomputer/omicron#3895 (comment)

Current Implementation:

steno/src/dag.rs

Lines 387 to 405 in 77d8f20

	impl<'a> Iterator for SagaDagIterator<'a> {
	type Item = NodeEntry<'a>;
	fn next(&mut self) -> Option<Self::Item> {
	while let Some(node) = self.dag.get(self.index) {
	let index = self.index;
	self.index = NodeIndex::new(self.index.index() + 1);
	match node {
	InternalNode::Action { .. }
	| InternalNode::Constant { .. }
	| InternalNode::SubsagaEnd { .. } => {
	return Some(NodeEntry { internal: node, index })
	}
	_ => (),
	}
	}
	None
	}
	}

Advantages of doing this:

• It would be easier to iterate over the nodes under saga idempotency tests

[smklein]

After taking a brief look at this, I don't think this is trivial -- though I'd love to reach into SagaDag.graph and just query for the node_count (https://docs.rs/petgraph/latest/petgraph/graph/struct.Graph.html#method.node_count) , I don't think it's so simple.

• The iterator walks over all named nodes, not all nodes.
• The Start, End, and SubSagaStart nodes don't have names, and would thus need to be omitted from the count.

Therefore, we would need to track the count of all subsagas to be able to infer the named node count (graph.node_count() - (2 + subsaga_count)). This would introduce additional accounting that would need to exist test-only cases.