From 77e98a8d38ae1933f4e004663cdf52e30b115991 Mon Sep 17 00:00:00 2001 From: Rahul R Date: Tue, 17 Mar 2026 11:52:52 +0000 Subject: [PATCH 1/3] Install numpy as part of installer if numpy is used in module --- build/templates/setup.py.mako | 6 ++++++ generated/nifake/setup.py | 1 + generated/nirfsg/setup.py | 1 + 3 files changed, 8 insertions(+) diff --git a/build/templates/setup.py.mako b/build/templates/setup.py.mako index 3f8340534..1253448bd 100644 --- a/build/templates/setup.py.mako +++ b/build/templates/setup.py.mako @@ -6,6 +6,9 @@ import build.helper as helper config = template_parameters['metadata'].config grpc_supported = template_parameters['include_grpc_support'] module_version = config['module_version'] +functions = config['functions'] +functions = helper.filter_codegen_functions(functions) +are_complex_parameters_used = helper.are_complex_parameters_used(functions) %> from setuptools import setup @@ -41,6 +44,9 @@ setup( % if config['uses_nitclk']: 'nitclk', % endif + % if are_complex_parameters_used: + 'numpy', + % endif ], % if grpc_supported: extras_require={ diff --git a/generated/nifake/setup.py b/generated/nifake/setup.py index bc350d42a..9807028a4 100644 --- a/generated/nifake/setup.py +++ b/generated/nifake/setup.py @@ -33,6 +33,7 @@ def read_contents(file_to_read): install_requires=[ 'hightime>=0.2.0', 'nitclk', + 'numpy', ], extras_require={ 'grpc': [ diff --git a/generated/nirfsg/setup.py b/generated/nirfsg/setup.py index c1428600e..5f6a6e009 100644 --- a/generated/nirfsg/setup.py +++ b/generated/nirfsg/setup.py @@ -33,6 +33,7 @@ def read_contents(file_to_read): install_requires=[ 'hightime>=0.2.0', 'nitclk', + 'numpy', ], classifiers=[ "Development Status :: 4 - Beta", From df29fdd9cbaa66c06b7f7a050032f8a169795493 Mon Sep 17 00:00:00 2001 From: Rahul R Date: Tue, 17 Mar 2026 12:05:47 +0000 Subject: [PATCH 2/3] Updated Changelog.md file --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index d6dd1d177..5b009dd4c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1705,6 +1705,7 @@ - `get_script` and `delete_script` methods - `SCRIPTS` added to enum `LoadOptions` - `DO_NOT_DRIVE_SIGNAL` added to enum `PulseModulationSource` + - `numpy` as an install dependency for modules that use numpy values - Changed - Removed From c55b7e256511183f26b0f617bbf609d36c220bf7 Mon Sep 17 00:00:00 2001 From: Rahul R Date: Tue, 17 Mar 2026 12:34:36 +0000 Subject: [PATCH 3/3] Code review updates --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5b009dd4c..668c63410 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1705,7 +1705,7 @@ - `get_script` and `delete_script` methods - `SCRIPTS` added to enum `LoadOptions` - `DO_NOT_DRIVE_SIGNAL` added to enum `PulseModulationSource` - - `numpy` as an install dependency for modules that use numpy values + - `numpy` is now an install dependency - Changed - Removed