-
Notifications
You must be signed in to change notification settings - Fork 220
Open
Description
Problem
When external contributors submit PRs from forks, the GitHub Actions workflows don't show the "Approve and run" button that repo maintainers need to click to allow the workflows to run. This means fork PRs get no CI feedback.
Investigation needed
- Check the repo's Actions settings under Settings > Actions > General > "Fork pull request workflows from outside collaborators" — it should be set to "Require approval for first-time contributors" or "Require approval for all outside collaborators"
- The
setup-cached-buildcomposite action requires GCP secrets (GCPV2_WORKLOAD_IDENTITY_POOL_PROJECT_NUMBER) viavars.*— these aren't available to fork PRs. The workflow may need a fallback path that skips caching when secrets aren't available. - Consider whether
pull_request_targetis needed instead ofpull_requestfor some workflows —pull_request_targetruns in the context of the base branch and has access to secrets, but requires careful handling to avoid security issues.
Affected workflows
All GHA workflows that use setup-cached-build:
check-experimenter.ymlcheck-cirrus.ymlcheck-feature-manifests.ymlcheck-schemas.ymlintegration-nimbus-ui.yml(new)integration-remote-settings-launch.yml(new)integration-remote-settings-all.yml(new)integration-desktop-enrollment.yml(new)integration-desktop-targeting.yml(new)
Related
Part of the CircleCI to GHA migration (EXP-6320). CircleCI handled fork PRs automatically.
┆Issue is synchronized with this Jira Task
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels