Skip to content

GHA workflows don't show 'Approve and run' button for fork PRs #14966

@jaredlockhart

Description

@jaredlockhart

Problem

When external contributors submit PRs from forks, the GitHub Actions workflows don't show the "Approve and run" button that repo maintainers need to click to allow the workflows to run. This means fork PRs get no CI feedback.

Investigation needed

  1. Check the repo's Actions settings under Settings > Actions > General > "Fork pull request workflows from outside collaborators" — it should be set to "Require approval for first-time contributors" or "Require approval for all outside collaborators"
  2. The setup-cached-build composite action requires GCP secrets (GCPV2_WORKLOAD_IDENTITY_POOL_PROJECT_NUMBER) via vars.* — these aren't available to fork PRs. The workflow may need a fallback path that skips caching when secrets aren't available.
  3. Consider whether pull_request_target is needed instead of pull_request for some workflows — pull_request_target runs in the context of the base branch and has access to secrets, but requires careful handling to avoid security issues.

Affected workflows

All GHA workflows that use setup-cached-build:

  • check-experimenter.yml
  • check-cirrus.yml
  • check-feature-manifests.yml
  • check-schemas.yml
  • integration-nimbus-ui.yml (new)
  • integration-remote-settings-launch.yml (new)
  • integration-remote-settings-all.yml (new)
  • integration-desktop-enrollment.yml (new)
  • integration-desktop-targeting.yml (new)

Related

Part of the CircleCI to GHA migration (EXP-6320). CircleCI handled fork PRs automatically.

┆Issue is synchronized with this Jira Task

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions