From ab7366b12d8991d800c3a8237727a99d7b0123ff Mon Sep 17 00:00:00 2001 From: Curtis Morales Date: Thu, 9 Apr 2026 15:48:13 -0400 Subject: [PATCH 1/4] Format serp_categories field in suggestion data --- jobs/quicksuggest2bq/quicksuggest2bq/main.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/jobs/quicksuggest2bq/quicksuggest2bq/main.py b/jobs/quicksuggest2bq/quicksuggest2bq/main.py index 8f63c89e..87512021 100644 --- a/jobs/quicksuggest2bq/quicksuggest2bq/main.py +++ b/jobs/quicksuggest2bq/quicksuggest2bq/main.py @@ -101,6 +101,10 @@ def download_suggestions(client: kinto_http.Client) -> Iterator[KintoSuggestion] {"keyword": kw, "count": count} for kw, count in suggestion_data.get("full_keywords", []) ], + "serp_categories": [ + {"category": category_id} + for category in suggestion_data.get("serp_categories", []) + ], } yield KintoSuggestion(**suggestion) From 540962c7c47dc3e8726df2295624fa5cf87344c3 Mon Sep 17 00:00:00 2001 From: Curtis Morales Date: Thu, 9 Apr 2026 15:53:04 -0400 Subject: [PATCH 2/4] Update test --- jobs/quicksuggest2bq/tests/test_main.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/jobs/quicksuggest2bq/tests/test_main.py b/jobs/quicksuggest2bq/tests/test_main.py index 8ae29bfb..fa5125a1 100644 --- a/jobs/quicksuggest2bq/tests/test_main.py +++ b/jobs/quicksuggest2bq/tests/test_main.py @@ -135,7 +135,8 @@ def test_suggestion_full_keyword(self, mocked_kinto_client): def test_suggestion_serp_categories(self, mocked_kinto_client): suggestions = list(download_suggestions(mocked_kinto_client)) - assert suggestions[0].serp_categories == SERP_CATEGORIES + assert suggestions[0].serp_categories[0]["category"] == 1 + assert suggestions[0].serp_categories[0]["category"] == 2 def test_suggestion_score(self, mocked_kinto_client): suggestions = list(download_suggestions(mocked_kinto_client)) From cc7b947759ac645a92b61668562528b869744df0 Mon Sep 17 00:00:00 2001 From: Curtis Morales Date: Thu, 9 Apr 2026 16:08:15 -0400 Subject: [PATCH 3/4] Fix list comprehension --- jobs/quicksuggest2bq/quicksuggest2bq/main.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/jobs/quicksuggest2bq/quicksuggest2bq/main.py b/jobs/quicksuggest2bq/quicksuggest2bq/main.py index 87512021..f5b84960 100644 --- a/jobs/quicksuggest2bq/quicksuggest2bq/main.py +++ b/jobs/quicksuggest2bq/quicksuggest2bq/main.py @@ -103,7 +103,7 @@ def download_suggestions(client: kinto_http.Client) -> Iterator[KintoSuggestion] ], "serp_categories": [ {"category": category_id} - for category in suggestion_data.get("serp_categories", []) + for category_id in suggestion_data.get("serp_categories", []) ], } yield KintoSuggestion(**suggestion) From 6895ad5ffb2e62ec89974cd1af4d27125bd006fa Mon Sep 17 00:00:00 2001 From: Curtis Morales Date: Thu, 9 Apr 2026 16:10:45 -0400 Subject: [PATCH 4/4] Fix test --- jobs/quicksuggest2bq/tests/test_main.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/jobs/quicksuggest2bq/tests/test_main.py b/jobs/quicksuggest2bq/tests/test_main.py index fa5125a1..185a9535 100644 --- a/jobs/quicksuggest2bq/tests/test_main.py +++ b/jobs/quicksuggest2bq/tests/test_main.py @@ -136,7 +136,7 @@ def test_suggestion_full_keyword(self, mocked_kinto_client): def test_suggestion_serp_categories(self, mocked_kinto_client): suggestions = list(download_suggestions(mocked_kinto_client)) assert suggestions[0].serp_categories[0]["category"] == 1 - assert suggestions[0].serp_categories[0]["category"] == 2 + assert suggestions[0].serp_categories[1]["category"] == 2 def test_suggestion_score(self, mocked_kinto_client): suggestions = list(download_suggestions(mocked_kinto_client))