RunwayInfo ranges yield 0 when no visibility information is provided

[f-loris]

For RunwayInfo's, when there is no visibility information or only one of both set, it returns 0 for these ranges since they are a primitive.

MetarParser/metarParser-entities/src/main/java/io/github/mivek/model/RunwayInfo.java

Line 19 in 35f7e55

private int minRange;

I'd suggest to change int to an Integer so that is handled properly and yields null when no value has been provided.

[mivek]

Hello @f-loris

There is indeed an implementation issue with the visibility information when only one is set in the METAR message.
R01L/0800FT will only have the minRange set to 800 but the maxRange will be 0.

It actually happens on this line

MetarParser/metarParser-parsers/src/main/java/io/github/mivek/command/metar/RunwayCommand.java

Line 129 in 24a265f

ri.setMinRange(Integer.parseInt(matches[3]));

Instead of changing the types of the attribute, another way of fixing it is to set both minRange and maxRange to the same value.

What do you think of this?

[f-loris]

Hello @mivek ,

Thanks for coming back. Your suggestion is already an improvement, but I'd still prefer changing it to a nullable type due to the following reasons:

• There is a value set which was not provided by the METAR (e.g. even when no min/max is set it still provides a value).
• According to your sample of setting minRange and maxRange to the same value, the user has no possibility to verify if this was provided like that in the METAR or it is the case you mentioned.
• An Integer would be more consistent with other implementations. E.g. minVisibility is also nullable.

  MetarParser/metarParser-entities/src/main/java/io/github/mivek/model/Visibility.java

  Line 15 in 35f7e55

  private Integer minVisibility;

If you'd like to avoid to change from int to Integer I'd suggest at least to initialize the int with something like -1 or so to allow any user to verify if a value was provided or not.

[mivek]

Hello @f-loris

I made a PR to change the type of minRange and maxRange to Integer. I let you check it