Bug in Tx Queue with fragment being checked

[coolstar]

According to comment here: https://github.com/microsoft/NetAdapter-Cx-Driver-Samples/blob/release_2004/RtEthSample/txqueue.cpp#L292 the last fragment should be checked

but at https://github.com/microsoft/NetAdapter-Cx-Driver-Samples/blob/release_2004/RtEthSample/txqueue.cpp#L290C6-L290C6 it's checking the first fragment.

On a similar driver I've written for RTL8168/RTL8125, this bug causes the Tx Queue to randomly stop sending packets. Fixing it to use the last fragment (like so coolstar/if_re-win@14e3319) seems to fix the issue and get more stable iperf transfers.

Still have more testing to do, but seems to be stable so far.

[tylerretzlaff]

I agree, looks like a bug. From: CoolStar ***@***.***> Sent: Saturday, January 13, 2024 4:58 PM To: microsoft/NetAdapter-Cx-Driver-Samples ***@***.***> Cc: Subscribed ***@***.***> Subject: [microsoft/NetAdapter-Cx-Driver-Samples] Bug in Tx Queue with fragment being checked (Issue #16) According to comment here: https://github.com/microsoft/NetAdapter-Cx-Driver-Samples/blob/release_2004/RtEthSample/txqueue.cpp#L292 the last fragment should be checked but at https://github.com/microsoft/NetAdapter-Cx-Driver-Samples/blob/release_2004/RtEthSample/txqueue.cpp#L290C6-L290C6 it's checking the first fragment. On a similar driver I've written for RTL8168/RTL8125, this bug causes the Tx Queue to randomly stop sending packets. Fixing it to use the last fragment (like so ***@***.***<coolstar/if_re-win@14e3319>) seems to fix the issue and get more stable iperf transfers. Still have more testing to do, but seems to be stable so far. - Reply to this email directly, view it on GitHub<#16> or unsubscribe<https://github.com/notifications/unsubscribe-auth/AGDOGHPRQ36QYBVHDOVVV33YOMURVBFKMF2HI4TJMJ2XIZLTSOBKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJLJONZXKZNENZQW2ZNLORUHEZLBMRPXI6LQMWBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTLDTOVRGUZLDORPXI6LQMWSUS43TOVS2M5DPOBUWG44SQKSHI6LQMWVHEZLQN5ZWS5DPOJ42K5TBNR2WLKBYG4ZDENBUGMYYFJDUPFYGLJLJONZXKZNFOZQWY5LFVIZDAOBQGUZTIMRTGCTXI4TJM5TWK4VGMNZGKYLUMU>. You are receiving this email because you are subscribed to this thread. Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.