Dear all,
With latest update, which allowed to increase the number of maximum nodes using kwargs dict inside registry(...) function, the default parameters are 100 nodes,
|
maximum_node_count: int = 100, |
, which makes action_space for local, remote and connect to be especially large.
Although, that does not change the logic of computing
action_mask and set valid node id to be nax number of discovered nodes, internally vector is set to be too big.
- Question: I want to ask for the logic of change from using
max_node_count parameter here
|
max_node_count = self.bounds.maximum_node_count |
, why we want to have option to enlarge the maximum nodes count using registry and this we had to change the value from inferred form initial_network to the one included in bounds for registry function?
- Solution: The workaround as I see can be simply to make this parameters
maximum_node_count: int | None and then make if else logic for setting them equal to initial number of parameters from network (done in previous commits from main)
Dear all,
With latest update, which allowed to increase the number of maximum nodes using kwargs dict inside registry(...) function, the default parameters are 100 nodes,
CyberBattleSim/cyberbattle/_env/cyberbattle_env.py
Line 390 in 4fd228b
Although, that does not change the logic of computing
action_maskand set valid node id to be nax number of discovered nodes, internally vector is set to be too big.max_node_countparameter hereCyberBattleSim/cyberbattle/_env/cyberbattle_env.py
Line 608 in 4fd228b
maximum_node_count: int | Noneand then make if else logic for setting them equal to initial number of parameters from network (done in previous commits from main)