Branch Protection Rules for main

[abe-101]

Hey @niccokunzmann & @SashankBhamidi

Opening up this discussion so we can talk about what branch protection rules we want in place for this repo.

To kick things off, I've gone ahead and made some changes to the main branch rules:

• PRs are now required before merging
• At least one approval is required before a PR can be merged
• Stale approvals are dismissed when new commits are pushed (so if you push more code after getting approved, you'll need a fresh review)
• Status checks must pass before merging
• @niccokunzmann has been granted bypass access - didn't want you getting held up if I'm not around to review

This is my ideal setup for the repo, but I'm not trying to impose anything. If this becomes inconvenient for anyone, I'm totally open to changing it. Let's discuss here!

[abe-101]

Also what access role do you need @SashankBhamidi ? for now I've given maintain

[SashankBhamidi]

Temporarily, I think it's okay. A role that has write access to a feature branch would have been enough as a collaborator though.

[SashankBhamidi]

I think these rules are ok.

I'd maybe say disable the status checks, because I've often found them not working, and unless someone has bypass won't be able to merge the PR even if CI is green.

Do you want to have the same settings as icalendar, and anonymizer? In that case, we can summon Steve into this thread.

[abe-101]

I don't want to bother steve at the moment. We can revisit later.
I've added you to the list of users who can bypass the checks