-
Notifications
You must be signed in to change notification settings - Fork 0
FOLLOW-UP: Extract shared utility functions from source and runtime packages (from PR #215) #219
Copy link
Copy link
Open
Labels
P2-mediumMedium: quality, platform coverage, CIMedium: quality, platform coverage, CIfollow-upFollow-up task from PR reviewFollow-up task from PR reviewfrom-reviewIssue originated from PR reviewIssue originated from PR review
Description
Context
This follow-up task was identified during the review of PR #215.
Source PR: #215
PR Title: feat: add computed source type for derived/aggregated data
Suggested by: Code reuse review
Task Description
Several utility functions are duplicated between internal/source/computed.go and internal/runtime/expr.go:
getField/getFieldValue— case-insensitive field lookup on row mapstoFloat64/tryFloat64— numeric type conversion with different coveragesumValues/sumField— field aggregation with divergent error handlingapplyFilter/filterData— row filtering with different comparison semantics
These have subtly different behavior (e.g., computed.go skips non-numeric silently while expr.go returns errors). A shared internal/fieldutil package would consolidate these and ensure consistent behavior.
This issue was automatically created by prmonitor from PR review comments.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
P2-mediumMedium: quality, platform coverage, CIMedium: quality, platform coverage, CIfollow-upFollow-up task from PR reviewFollow-up task from PR reviewfrom-reviewIssue originated from PR reviewIssue originated from PR review