-
Notifications
You must be signed in to change notification settings - Fork 0
FOLLOW-UP: Make patchSchemaWithRole more robust (from PR #273) #275
Copy link
Copy link
Open
Labels
follow-upFollow-up task from PR reviewFollow-up task from PR reviewfrom-reviewIssue originated from PR reviewIssue originated from PR review
Description
Context
This follow-up task was identified during the review of PR #273.
Source PR: #273
PR Title: feat: add authorization / RBAC system (Roadmap 2.3)
Suggested by: @claude[bot], @copilot
Task Description
patchSchemaWithRole in internal/generator/authz.go uses hardcoded string patterns to find the insertion point in schema.sql. If the auth generator changes whitespace or column ordering, the patterns silently fail.
Options:
- Use regex to match
CREATE TABLE <tableName>block and find the insertion point - Scope the "already patched" check to the specific table, not the whole file
- Generate the role column as part of
lvt gen authfrom the start (eliminates patching)
This issue was automatically created by prmonitor from PR review comments.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
follow-upFollow-up task from PR reviewFollow-up task from PR reviewfrom-reviewIssue originated from PR reviewIssue originated from PR review