From dc009456e13b465fcb0e182acddf974ec935f573 Mon Sep 17 00:00:00 2001 From: Adnaan Date: Sun, 30 Nov 2025 00:20:19 +0100 Subject: [PATCH 1/2] fix: update to new lvt testing API MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Update all examples to use the new lvt testing API: - StartDockerChrome now returns error instead of *exec.Cmd - StopDockerChrome now takes (t, debugPort) instead of (t, cmd, debugPort) This aligns with the latest lvt/testing package changes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude --- avatar-upload/avatar-upload_test.go | 6 ++++-- counter/counter_test.go | 6 ++++-- todos/todos_test.go | 6 ++++-- 3 files changed, 12 insertions(+), 6 deletions(-) diff --git a/avatar-upload/avatar-upload_test.go b/avatar-upload/avatar-upload_test.go index 8eef97e..2285013 100644 --- a/avatar-upload/avatar-upload_test.go +++ b/avatar-upload/avatar-upload_test.go @@ -47,8 +47,10 @@ func TestAvatarUploadE2E(t *testing.T) { }() // Start Docker Chrome container - chromeCmd := e2etest.StartDockerChrome(t, debugPort) - defer e2etest.StopDockerChrome(t, chromeCmd, debugPort) + if err := e2etest.StartDockerChrome(t, debugPort); err != nil { + t.Fatalf("Failed to start Chrome: %v", err) + } + defer e2etest.StopDockerChrome(t, debugPort) // Connect to Docker Chrome via remote debugging chromeURL := fmt.Sprintf("http://localhost:%d", debugPort) diff --git a/counter/counter_test.go b/counter/counter_test.go index 58cae2b..c0fe84f 100644 --- a/counter/counter_test.go +++ b/counter/counter_test.go @@ -52,8 +52,10 @@ func TestCounterE2E(t *testing.T) { }() // Start Docker Chrome container - chromeCmd := e2etest.StartDockerChrome(t, debugPort) - defer e2etest.StopDockerChrome(t, chromeCmd, debugPort) + if err := e2etest.StartDockerChrome(t, debugPort); err != nil { + t.Fatalf("Failed to start Chrome: %v", err) + } + defer e2etest.StopDockerChrome(t, debugPort) // Connect to Docker Chrome via remote debugging chromeURL := fmt.Sprintf("http://localhost:%d", debugPort) diff --git a/todos/todos_test.go b/todos/todos_test.go index a06ec47..1b9ccdd 100644 --- a/todos/todos_test.go +++ b/todos/todos_test.go @@ -104,8 +104,10 @@ func TestTodosE2E(t *testing.T) { t.Logf("✅ Test server ready at %s", serverURL) // Start Docker Chrome container - chromeCmd := e2etest.StartDockerChrome(t, debugPort) - defer e2etest.StopDockerChrome(t, chromeCmd, debugPort) + if err := e2etest.StartDockerChrome(t, debugPort); err != nil { + t.Fatalf("Failed to start Chrome: %v", err) + } + defer e2etest.StopDockerChrome(t, debugPort) // Connect to Docker Chrome via remote debugging chromeURL := fmt.Sprintf("http://localhost:%d", debugPort) From 039b5d23da4c9b76a249623901062c3efc412c6e Mon Sep 17 00:00:00 2001 From: Adnaan Date: Sun, 30 Nov 2025 07:06:14 +0100 Subject: [PATCH 2/2] fix: revert to published lvt testing API MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The previous commit assumed the new lvt testing API was published, but the new API (StartDockerChrome returning error, StopDockerChrome taking 2 args) is still unpushed in the local lvt repo. Reverting to the published API: - StartDockerChrome returns *exec.Cmd - StopDockerChrome takes (t, cmd, debugPort) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude --- avatar-upload/avatar-upload_test.go | 6 ++---- counter/counter_test.go | 6 ++---- todos/todos_test.go | 6 ++---- 3 files changed, 6 insertions(+), 12 deletions(-) diff --git a/avatar-upload/avatar-upload_test.go b/avatar-upload/avatar-upload_test.go index 2285013..8eef97e 100644 --- a/avatar-upload/avatar-upload_test.go +++ b/avatar-upload/avatar-upload_test.go @@ -47,10 +47,8 @@ func TestAvatarUploadE2E(t *testing.T) { }() // Start Docker Chrome container - if err := e2etest.StartDockerChrome(t, debugPort); err != nil { - t.Fatalf("Failed to start Chrome: %v", err) - } - defer e2etest.StopDockerChrome(t, debugPort) + chromeCmd := e2etest.StartDockerChrome(t, debugPort) + defer e2etest.StopDockerChrome(t, chromeCmd, debugPort) // Connect to Docker Chrome via remote debugging chromeURL := fmt.Sprintf("http://localhost:%d", debugPort) diff --git a/counter/counter_test.go b/counter/counter_test.go index c0fe84f..58cae2b 100644 --- a/counter/counter_test.go +++ b/counter/counter_test.go @@ -52,10 +52,8 @@ func TestCounterE2E(t *testing.T) { }() // Start Docker Chrome container - if err := e2etest.StartDockerChrome(t, debugPort); err != nil { - t.Fatalf("Failed to start Chrome: %v", err) - } - defer e2etest.StopDockerChrome(t, debugPort) + chromeCmd := e2etest.StartDockerChrome(t, debugPort) + defer e2etest.StopDockerChrome(t, chromeCmd, debugPort) // Connect to Docker Chrome via remote debugging chromeURL := fmt.Sprintf("http://localhost:%d", debugPort) diff --git a/todos/todos_test.go b/todos/todos_test.go index 1b9ccdd..a06ec47 100644 --- a/todos/todos_test.go +++ b/todos/todos_test.go @@ -104,10 +104,8 @@ func TestTodosE2E(t *testing.T) { t.Logf("✅ Test server ready at %s", serverURL) // Start Docker Chrome container - if err := e2etest.StartDockerChrome(t, debugPort); err != nil { - t.Fatalf("Failed to start Chrome: %v", err) - } - defer e2etest.StopDockerChrome(t, debugPort) + chromeCmd := e2etest.StartDockerChrome(t, debugPort) + defer e2etest.StopDockerChrome(t, chromeCmd, debugPort) // Connect to Docker Chrome via remote debugging chromeURL := fmt.Sprintf("http://localhost:%d", debugPort)