Skip to content

FOLLOW-UP: Document breaking changes in changelog/migration guide (from PR #45) #48

@adnaan

Description

@adnaan

Context

This follow-up task was identified during the review of PR #45.

Source PR: #45
Suggested by: @claude[bot]

Task Description

The following breaking changes need to be documented in the changelog and/or migration guide:

  1. Attribute renames (silent breaking changes):

    • lvt-no-interceptlvt-nav:no-intercept (links)
    • lvt-no-interceptlvt-form:no-intercept (forms)
  2. Action field behavior change:

    • action form field is no longer reserved/excluded — it now flows through to ActionData
    • Routing now uses lvt-action hidden field (server) or lvt-form:action attribute (client)
  3. Phase 1A attribute renames (from PR Phase 1A: Client attribute reduction — generic event router + removals #44):

    • lvt-clicklvt-on:click
    • lvt-submitlvt-on:submit
    • lvt-debouncelvt-mod:debounce
    • lvt-throttlelvt-mod:throttle
    • Modal JS removed (use native <dialog>)

Original Comment

These are reasonable breaking changes, but the PR description should call them out explicitly, and if there's a changelog/migration guide it should be updated before merge.


This issue was automatically created by prmonitor from PR review comments.

Metadata

Metadata

Assignees

No one assigned

    Labels

    follow-upFollow-up task from PR reviewfrom-reviewIssue originated from PR review

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions