-
Notifications
You must be signed in to change notification settings - Fork 0
FOLLOW-UP: Document breaking changes in changelog/migration guide (from PR #45) #48
Copy link
Copy link
Open
Labels
follow-upFollow-up task from PR reviewFollow-up task from PR reviewfrom-reviewIssue originated from PR reviewIssue originated from PR review
Description
Context
This follow-up task was identified during the review of PR #45.
Source PR: #45
Suggested by: @claude[bot]
Task Description
The following breaking changes need to be documented in the changelog and/or migration guide:
-
Attribute renames (silent breaking changes):
lvt-no-intercept→lvt-nav:no-intercept(links)lvt-no-intercept→lvt-form:no-intercept(forms)
-
Action field behavior change:
actionform field is no longer reserved/excluded — it now flows through to ActionData- Routing now uses
lvt-actionhidden field (server) orlvt-form:actionattribute (client)
-
Phase 1A attribute renames (from PR Phase 1A: Client attribute reduction — generic event router + removals #44):
lvt-click→lvt-on:clicklvt-submit→lvt-on:submitlvt-debounce→lvt-mod:debouncelvt-throttle→lvt-mod:throttle- Modal JS removed (use native
<dialog>)
Original Comment
These are reasonable breaking changes, but the PR description should call them out explicitly, and if there's a changelog/migration guide it should be updated before merge.
This issue was automatically created by prmonitor from PR review comments.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
follow-upFollow-up task from PR reviewFollow-up task from PR reviewfrom-reviewIssue originated from PR reviewIssue originated from PR review