Skip to content

FOLLOW-UP: Add backward-compat shim for lvt-no-intercept (from PR #45) #46

@adnaan

Description

@adnaan

Context

This follow-up task was identified during the review of PR #45.

Source PR: #45
PR Title: fix: lvt-form:action routing, lvt-nav:no-intercept, unreserve action field
Suggested by: @claude[bot]

Task Description

The rename of lvt-no-interceptlvt-nav:no-intercept (links) and lvt-form:no-intercept (forms) is a silent breaking change. Any existing HTML using lvt-no-intercept will silently stop working — forms/links will be intercepted again without any error or warning.

Options:

  1. Add a deprecation shim that checks for the old attribute and logs a console warning
  2. Support both old and new attribute names during a transition period
  3. If pre-1.0 / internal-only, just document the breaking change in release notes

Original Comment

Both attribute renames are silent breaking changes. Any existing HTML using lvt-no-intercept will silently stop working — forms/links that should be excluded will start getting intercepted. Consider a deprecation shim or a warning in the console when the old attribute is detected.


This issue was automatically created by prmonitor from PR review comments.

Metadata

Metadata

Assignees

No one assigned

    Labels

    follow-upFollow-up task from PR reviewfrom-reviewIssue originated from PR review

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions