Skip to content

bug: --announce-only is silently dropped in stake/liquidity/crowd commands #898

@bitloi

Description

@bitloi

Several CLI commands accept --announce-only but never actually use it — the flag is parsed and validated, then silently dropped before reaching the downstream command functions.

This means users passing --proxy --announce-only get a normal extrinsic execution instead of a proxy announcement, with no warning that the flag was ignored.

Affected commands include stake (add, remove, move, transfer, swap), liquidity (add, remove, modify), crowd (create, contribute, withdraw, finalize, update, refund, dissolve), and others like wallet set-id, wallet associate-hotkey, sudo set, subnets create, etc. — 37 CLI methods in total.

The underlying extrinsic API (sign_and_send_extrinsic) / sign_and_send_batch_extrinsic) already supports announce_only, but full announce-only UX (branched success messaging, slippage disclaimers) hasn't been implemented yet. Until that's done in v10, these flags should be removed so users aren't misled by a non-functional option.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions