-
Notifications
You must be signed in to change notification settings - Fork 171
pants check fails on services/processors.py due to re-introduced no-infer-dep comments #10778
Copy link
Copy link
Open
Open
Copy link
Description
pants check src/ai/backend/manager/services/processors.py fails with 124 [import-not-found] mypy errors on the main branch.
Root Cause
Commit 019e155 (fix(BA-4935)) removed all # pants: no-infer-dep comments from TYPE_CHECKING imports in processors.py to fix this exact issue. However, the immediately following commit 2e9e8d9 (feat(BA-4829)) re-introduced # pants: no-infer-dep on all 128 TYPE_CHECKING imports. Subsequent commits (RuntimeVariant, ModelCard, DeploymentRevisionPreset, etc.) continued the same pattern.
Impact
- pants check on processors.py (and any file that transitively includes it) is broken
- mypy cannot resolve any TYPE_CHECKING imports because pants excludes them from the sandbox
Fix
Remove all # pants: no-infer-dep comments from TYPE_CHECKING imports in processors.py.
Side Effects
- No circular dependency risk — dependents are API-layer files; dependencies are service-layer files (no upward imports)
- No runtime impact — imports remain under TYPE_CHECKING guard
- Build performance — processors.py dependency count increases from ~19 to ~100+, widening incremental invalidation scope for its 17 direct dependents. This is the same trade-off accepted in the original BA-4935 fix.
JIRA Issue: BA-5586
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels