From 4965e8c0dc2cd8464e6ac4af95fe84a16a5648f4 Mon Sep 17 00:00:00 2001 From: Tomaz Muraus Date: Fri, 24 Jan 2020 19:27:44 +0100 Subject: [PATCH 1/6] Add missing python dependencies to requirements.txt and setup.py. Without does, the project doesn't install and work on Fedora 30. --- requirements.txt | 2 ++ setup.py | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/requirements.txt b/requirements.txt index f2d299b..11aac10 100644 --- a/requirements.txt +++ b/requirements.txt @@ -3,3 +3,5 @@ pychromecast bottle pycaption paste +pygobject +dbus-python diff --git a/setup.py b/setup.py index ec0c27a..7caed64 100644 --- a/setup.py +++ b/setup.py @@ -28,7 +28,8 @@ def long_description(): 'Programming Language :: Python', 'Programming Language :: Python :: 3', ], - install_requires=['pychromecast','bottle','pycaption','paste','html5lib'], + install_requires=['pychromecast','bottle','pycaption','paste','html5lib', + 'pygobject', 'dbus-python'], data_files=[ ('share/icons/hicolor/16x16/apps', ['icons/gnomecast_16.png']), ('share/icons/hicolor/48x48/apps', ['icons/gnomecast_48.png']), From c7e15a5a5b8f5edc30eacf7b328f131702c7dab2 Mon Sep 17 00:00:00 2001 From: Tomaz Muraus Date: Fri, 24 Jan 2020 19:30:13 +0100 Subject: [PATCH 2/6] Add info on installing it on Fedora to the readme. --- README.md | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/README.md b/README.md index 10fa0c3..0e65511 100644 --- a/README.md +++ b/README.md @@ -21,6 +21,7 @@ What's New Install ------- + Please run: ``` @@ -30,6 +31,27 @@ $ pip3 install gnomecast If installing in a `mkvirtualenv` built virtual environment, make sure you include the `--system-site-packages` parameter to get the GTK bindings. +Fedora +~~~~~~ + +1. Install OS level dependencies + +```bash +sudo dnf install ffmpeg cairo-gobject-devel gobject-introspection-devel dbus-devel cairo-devel +``` + +2. Install Python dependencies + +```bash +pip install pygobject dbus-python +``` + +3. Install the application itself + +```bash +pip install gnomecast +``` + Run --- From f1780fa7099dac0e40c6abcd36c9ce1cc31fb5dc Mon Sep 17 00:00:00 2001 From: Tomaz Muraus Date: Fri, 24 Jan 2020 19:32:54 +0100 Subject: [PATCH 3/6] dbus is an optional dependency. --- README.md | 2 ++ requirements.txt | 1 - setup.py | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 0e65511..7c7a7a3 100644 --- a/README.md +++ b/README.md @@ -42,6 +42,8 @@ sudo dnf install ffmpeg cairo-gobject-devel gobject-introspection-devel dbus-dev 2. Install Python dependencies +NOTE: ``dbus-python`` is an optional dependency. + ```bash pip install pygobject dbus-python ``` diff --git a/requirements.txt b/requirements.txt index 11aac10..8934db4 100644 --- a/requirements.txt +++ b/requirements.txt @@ -4,4 +4,3 @@ bottle pycaption paste pygobject -dbus-python diff --git a/setup.py b/setup.py index 7caed64..270d61a 100644 --- a/setup.py +++ b/setup.py @@ -29,7 +29,7 @@ def long_description(): 'Programming Language :: Python :: 3', ], install_requires=['pychromecast','bottle','pycaption','paste','html5lib', - 'pygobject', 'dbus-python'], + 'pygobject'], data_files=[ ('share/icons/hicolor/16x16/apps', ['icons/gnomecast_16.png']), ('share/icons/hicolor/48x48/apps', ['icons/gnomecast_48.png']), From 8dc0a15e3c92fe7ee0a7f8913fe0ada02d6f9b52 Mon Sep 17 00:00:00 2001 From: Tomaz Muraus Date: Fri, 24 Jan 2020 19:36:02 +0100 Subject: [PATCH 4/6] Fix typo. --- gnomecast.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gnomecast.py b/gnomecast.py index 5bd1ca8..87afba2 100644 --- a/gnomecast.py +++ b/gnomecast.py @@ -33,7 +33,7 @@ line = "-"*70 ERROR_MESSAGE = """ {} -Python package "gi" (for building the GU not found.\n +Python package "gi" (for building the GUI not found.\n If on Debian or Ubuntu, please run: $ sudo apt-get install python3-gi\n For other distributions please look up the equivalent package.\n From 06fb8698ad9299a7ebc7e934bf41e6149599a3cb Mon Sep 17 00:00:00 2001 From: Tomaz Muraus Date: Fri, 24 Jan 2020 19:41:21 +0100 Subject: [PATCH 5/6] Update readme. --- README.md | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 7c7a7a3..2362d9a 100644 --- a/README.md +++ b/README.md @@ -34,6 +34,10 @@ If installing in a `mkvirtualenv` built virtual environment, make sure you inclu Fedora ~~~~~~ +This section describes how to install this application on Fedora inside a virtual environment +without relying on ``python3-gobject`` system level package and ``--system-site-packages`` +virtualenv flag. + 1. Install OS level dependencies ```bash @@ -45,13 +49,13 @@ sudo dnf install ffmpeg cairo-gobject-devel gobject-introspection-devel dbus-dev NOTE: ``dbus-python`` is an optional dependency. ```bash -pip install pygobject dbus-python +pip3 install pygobject dbus-python ``` 3. Install the application itself ```bash -pip install gnomecast +pip3 install gnomecast ``` Run From e4874ee8be58b84baf47f043e74d27ace28471ad Mon Sep 17 00:00:00 2001 From: Tomaz Muraus Date: Fri, 24 Jan 2020 19:41:27 +0100 Subject: [PATCH 6/6] Add info on package name in Fedora. --- gnomecast.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gnomecast.py b/gnomecast.py index 87afba2..6bf87e5 100644 --- a/gnomecast.py +++ b/gnomecast.py @@ -36,6 +36,8 @@ Python package "gi" (for building the GUI not found.\n If on Debian or Ubuntu, please run: $ sudo apt-get install python3-gi\n +If on Fedora or RedHat, please run: +$ sudo dnf install python3-gobject For other distributions please look up the equivalent package.\n If this doesn't work, please report the error here: https://github.com/keredson/gnomecast\n