two ScopedIpV4 having different interface_ids are considered as equal and lead to an unergonomic usage

[hrzlgnm]

I was playing around with the addition of interface_ids to ScopedIpV4 and I've discovered an inconvenience.

Lets say we have have an existing entry of a ScopedIp and want to compare it with another ScopedIp that was just resolved and another InterfaceId was added to an ScopedIpV4, both values will be considered as equal and the InterfaceId update gets missed.

I'm not 100% sure but I suspect the trait Eq implementation falls back to ParitalEq here:

mdns-sd/src/dns_parser.rs

Line 86 in 0661bf1

impl Eq for ScopedIpV4 {}

Which most likely leads to the observed behavior.

[keepsimple1]

Yeah, that's a valid point! I wasn't sure about ScopedIpV4 comparison semantics since the first time I added interface_id.

Now I think the issue is clearer, and I submitted a PR #446 to fix it. Let me know if it works for you.

[hrzlgnm]

Yeah, that's a valid point! I wasn't sure about ScopedIpV4 comparison semantics since the first time I added interface_id.

Now I think the issue is clearer, and I submitted a PR #446 to fix it. Let me know if it works for you.

Yes that fixes the issue.