Skip to content

Minor bug: unnecessary output_dir variable #38

@omgol411

Description

@omgol411

In main.py, in the functionrun_prism, if the args.output already exists, then the first condition is unmet and output_dir is still None. os.makedirs(output_dir) will throw the following error:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "<frozen os>", line 210, in makedirs
  File "<frozen posixpath>", line 103, in split
TypeError: expected str, bytes or os.PathLike object, not NoneType

Suggested fix:

  • output_dir seems unnecessary, replace L113-L117 with the following and remove the argument from the function run_prism.
os.makedirs(args.output, exist_ok=True)

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions