From 872797e456fea7316866340ab0bfb2b304679702 Mon Sep 17 00:00:00 2001 From: Erich Gubler Date: Fri, 22 Aug 2025 23:15:31 -0400 Subject: [PATCH] fix: properly apply `bindTextureResource` in `render_pass_descriptor:one_*_attachment` tests This is a bug in #4407, where this coverage was originally intended to be introduced. --- .../validation/render_pass/render_pass_descriptor.spec.ts | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/webgpu/api/validation/render_pass/render_pass_descriptor.spec.ts b/src/webgpu/api/validation/render_pass/render_pass_descriptor.spec.ts index 725c19553456..2aaa755a801e 100644 --- a/src/webgpu/api/validation/render_pass/render_pass_descriptor.spec.ts +++ b/src/webgpu/api/validation/render_pass/render_pass_descriptor.spec.ts @@ -115,9 +115,10 @@ g.test('attachments,one_color_attachment') .desc(`Test that a render pass works with only one color attachment.`) .paramsSubcasesOnly(u => u.combine('bindTextureResource', [false, true] as const)) .fn(t => { + const { bindTextureResource } = t.params; const colorTexture = t.createTestTexture({ format: 'rgba8unorm' }); const descriptor = { - colorAttachments: [t.getColorAttachment(colorTexture)], + colorAttachments: [t.getColorAttachment(colorTexture, { bindTextureResource })], }; t.tryRenderPass(true, descriptor); @@ -127,10 +128,13 @@ g.test('attachments,one_depth_stencil_attachment') .desc(`Test that a render pass works with only one depthStencil attachment.`) .paramsSubcasesOnly(u => u.combine('bindTextureResource', [false, true] as const)) .fn(t => { + const { bindTextureResource } = t.params; const depthStencilTexture = t.createTestTexture({ format: 'depth24plus-stencil8' }); const descriptor = { colorAttachments: [], - depthStencilAttachment: t.getDepthStencilAttachment(depthStencilTexture), + depthStencilAttachment: t.getDepthStencilAttachment(depthStencilTexture, { + bindTextureResource, + }), }; t.tryRenderPass(true, descriptor);