From c6839995f3b9585c28d47ef828c4c7264eb5e4a3 Mon Sep 17 00:00:00 2001 From: Guice Team Date: Mon, 7 Jul 2025 07:38:34 -0700 Subject: [PATCH] Tweak Guice to suggest `toProvider(() -> null)` rather than `toProvider(Providers.of(null))`. PiperOrigin-RevId: 780105053 --- .../com/google/inject/internal/AbstractBindingBuilder.java | 2 +- core/test/com/google/inject/BinderTest.java | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/core/src/com/google/inject/internal/AbstractBindingBuilder.java b/core/src/com/google/inject/internal/AbstractBindingBuilder.java index 15e86aae34..88542bdf62 100644 --- a/core/src/com/google/inject/internal/AbstractBindingBuilder.java +++ b/core/src/com/google/inject/internal/AbstractBindingBuilder.java @@ -41,7 +41,7 @@ public abstract class AbstractBindingBuilder { public static final String SCOPE_ALREADY_SET = "Scope is set more than once."; public static final String BINDING_TO_NULL = "Binding to null instances is not allowed. " - + "Use toProvider(Providers.of(null)) if this is your intended behaviour."; + + "Use toProvider(() -> null) if this is your intended behaviour."; public static final String CONSTANT_VALUE_ALREADY_SET = "Constant value is set more than once."; public static final String ANNOTATION_ALREADY_SPECIFIED = "More than one annotation is specified for this binding."; diff --git a/core/test/com/google/inject/BinderTest.java b/core/test/com/google/inject/BinderTest.java index 76b85371f9..cc731da7b1 100644 --- a/core/test/com/google/inject/BinderTest.java +++ b/core/test/com/google/inject/BinderTest.java @@ -223,8 +223,8 @@ public void configure() { } catch (CreationException expected) { assertContains( expected.getMessage(), - "1) Binding to null instances is not allowed. Use toProvider(Providers.of(null))", - "2) Binding to null instances is not allowed. Use toProvider(Providers.of(null))"); + "1) Binding to null instances is not allowed. Use toProvider(() -> null)", + "2) Binding to null instances is not allowed. Use toProvider(() -> null)"); } }