Mac laptops (and Apple keyboards) don't have an Insert key

[fdstevex]

Just started trying out Friction on macOS, and I noticed the View menu shows the shortcut for the "Add Key(s)" menu item as a missing Unicode glyph.

You can connect a Windows keyboard to a Mac, but none of Apple's keyboards include an insert key, so this isn't a great shortcut to use for a common operation on macOS.

Looking through src/app/GUI/menu.cpp, there's already at least one other command that has a macOS override - Ctrl+Space - so there's a precedent for per-platform variation.

Since "Add Key(s)" is a common operation can I suggest a new shortcut of simply "K"? I could make this change macOS specific to avoid breaking people's muscle memory on other platforms.

[rodlie]

Forgot about that one :) Thanks for the report.

Maybe we should use 'k' for all platforms?

[fdstevex]

I'm fairly new to Friction so not in a great position to say, but as an outsider that seems like a good shortcut to me.

[rodlie]

We can wait on feedback from users. Worst case we use k only on Mac.

Shortcut manager is on the roadmap.

[fdstevex]

Another shortcut to add (as I continue to explore the app) - delete. The full-size Apple keyboard has both delete and backspace, but the laptops and smaller Magic Keyboards (which is most of them) only have have a key with "delete" written on it but it's actually Qt::Key_Backspace key in Qt.

The Qt docs show "Delete" is mapped to "Forward Delete" on macOS, and "Backspace" is mapped to "Delete". Strange thing to do.

https://doc.qt.io/qt-6/qkeysequence.html

But right now the effect is that on an Apple laptop, pressing the delete key does nothing.

[pgilfernandez]

That last one is not only documented but there is a pending PR about it.
But as @rodlie said the shortcuts manager is on the way and probably he priorizad that rather than start adding more hardcoded shortcuts.

[nuxttux]

Hi - Changing from Insert to K sounds fine, although it could be I thus continuing the similarities with Blender shortcuts.

On that topic: K is marked as Marker, but it doesn't do anything when I press it.

Also, I was working with the "Timeline in window" and there a bit of a disconnect with the keyboard shortcuts. Especially since the Tab key key doesn't toggle between Timeline and Canvas with the Timeline in window.
It works if I am on the Canvas window, press Tab and the blue highlight disappears - but it doesn't go to the timeline.

If I press Tab with the Timeline window active, nothing happens.

[rodlie]

Hi - Changing from Insert to K sounds fine, although it could be I thus continuing the similarities with Blender shortcuts.

On that topic: K is marked as Marker, but it doesn't do anything when I press it.

Marker is M. Is there something that says K?

Also, I was working with the "Timeline in window" and there a bit of a disconnect with the keyboard shortcuts. Especially since the Tab key key doesn't toggle between Timeline and Canvas with the Timeline in window. It works if I am on the Canvas window, press Tab and the blue highlight disappears - but it doesn't go to the timeline.

If I press Tab with the Timeline window active, nothing happens.

The Window Manager controls windows, so alt+tab. I control everything inside the windows :)

[nuxttux]

Marker is M. Is there something that says K?

The Keyboard shortcuts.

The Window Manager controls windows, so alt+tab. I control everything inside the windows :)

I'll do that in the meantime.

[rodlie]

The Keyboard shortcuts.

Ahh, then it's a typo. Probably my fault 😄 (k is very close to m).

[rodlie]

Typo fixed.