ParallelMidpointLocator doesn't rotate figures inside the label

[ittayd]

If I have a label and I add another figure to it. The label is rotated by the locator. But, the figure inside it remains in place (or, more likely, the locator associated with it, places it according to the old label placement).

I think that in general, the best approach is for each figure to have a local coordinate space and then child figures are placed in this space and to draw them globally, any matrix that applies to the figure is applied to them as well (and recursively if that figure is inside another)

[ittayd]

I did this which rotates the figures:

if (!draw2d.Figure.injected) {
  let prev = draw2d.Figure.prototype.setRotationAngle
  draw2d.Figure.inject({
    setRotationAngle: function(angle) {
console.log('rotating', this)
      const ret = prev.apply(this, [angle])
      this.children.each((i, e) =>  e.figure.setRotationAngle(angle))
      return ret
    },
  })

draw2d.Figure.injected = true
}

But in my case, the locator is LeftLocator which uses setPosition which is absolute. Seems like there should be an applyConsiderRotation method (taken from PortLocator) that all locators use instead of setPosition.

[ittayd]

I tried to use applyConsiderRotation instead of setPosition in LeftLocator. It doesn't work. The reason is that it calculates the offset according to the parent's bounding box that is in absolute space.

[ittayd]

I ended up creating these patches to LeftLocator and TopLocator. I achieved them using trial & error, and they work only for a 90 angle rotation.

LeftLocator:

 relocate: function (index, target) {
       const parent = target.getParent();
       if (parent.getRotationAngle() == 90) {
         const boundingBox = parent.getBoundingBox()
         let targetBoundingBox = target.getBoundingBox()

         target.setPosition(boundingBox.w / 2 - (targetBoundingBox.w / 2), -(boundingBox.w/2 + 2))
         //target.repaint()
         return;
       }
       return originals.leftRelocate.apply(this, [index, target])
}

TopLocator:

relocate: function (index, target) {
       const parent = target.getParent();
       if (parent.getRotationAngle() == 90) {
         const boundingBox = parent.getBoundingBox()
         let targetBoundingBox = target.getBoundingBox()

         target.setPosition(-(targetBoundingBox.w/2 - boundingBox.w/2) -  targetBoundingBox.h/2 - 4, 0)
         //target.repaint()
         return;
       }
       return originals.bottomRelocate.apply(this, [index, target])
}