ArtifactGenerator: exclude patterns fail to filter directories

[noambenm]

Description:
In source-watcher v2.0.3, the exclude logic in ArtifactGenerator is not working for paths other than "**/dir/**"

Environment:

• Version: ghcr.io/fluxcd/source-watcher:v2.0.3
• Resource: ArtifactGenerator

Reproduction Steps:

1. Define an ArtifactGenerator with a subtree selection:

        spec:
          artifacts:
            - name: infrastructure
              copy:
                - from: "@monorepo/infrastructure/**"
                  to: "@artifact/"
                  exclude:
                    - "infrastructure/controllers/descheduler/**"

2. Observe the generated artifact.
3. Actual Behavior: The descheduler files are still present in the artifact and is being deployed.
4. Expected Behavior: The files should be excluded as the pattern matches the path relative to the source alias.

I have tried every possible other path, but no success, the resources are still being deployed., I would love to know if there is another way to specify the full path of the directories and not use "**/dir/**". my repo is structured exactly like the flux2-kustomize-helm-example repo.

[matheuscscp]

What if you change:

                  exclude:
                    - "infrastructure/controllers/descheduler/**"

to:

                  exclude:
                    - "infrastructure/controllers/descheduler/"

[noambenm]

Hi!
no unfortunately it still creates the resources

---
apiVersion: source.extensions.fluxcd.io/v1beta1
kind: ArtifactGenerator
metadata:
  name: flux-system
  namespace: flux-system
spec:
  sources:
    - alias: monorepo
      kind: GitRepository
      name: flux-system
  artifacts:
    - name: infrastructure
      originRevision: "@monorepo"
      copy:
        - from: "@monorepo/infrastructure/**"
          to: "@artifact/"
          exclude:
            - "infrastructure/controllers/descheduler/"

[stefanprodan]

The exclude is relative to the from path, try **/descheduler/**

[noambenm]

Yea **/descheduler/** is the only one (from my testing) that manages for exclude the directories from the ExternalArtifact, but I was wondering if there is a way to be more specific with the path because **/descheduler/** can possibly catch direcroties that I would like to include.

[stefanprodan]

This should also work **/controllers/descheduler/**

[noambenm]

Thats what I have thought too, but it still creates the resources

---
apiVersion: source.extensions.fluxcd.io/v1beta1
kind: ArtifactGenerator
metadata:
  name: flux-system
  namespace: flux-system
spec:
  sources:
    - alias: monorepo
      kind: GitRepository
      name: flux-system
  artifacts:
    - name: infrastructure
      originRevision: "@monorepo"
      copy:
        - from: "@monorepo/infrastructure/**"
          to: "@artifact/"
          exclude:
            - "**/controllers/descheduler/**"

the repo I'm testing this with is public at mdch-lab

[stefanprodan]

Ah it's because the relative path has infrastructure as root, try controllers/descheduler/** please.

[noambenm]

No still no dice

now that I have the deschduler deployed, the controllers/descheduler/** exclusion is not deleting it.

[noambenm]

Update:

I have now tried to exclude the following file **/configs/cilium/ip-pool.yaml and it ignores this line also and still keeps it in the artifact.

do we have any clue on why this is the behaviour?