From 8d6483a9eade7e47e64908cf8f4943fd50dc0672 Mon Sep 17 00:00:00 2001 From: Ruben Bridgewater Date: Mon, 5 Mar 2018 23:53:31 +0100 Subject: [PATCH] Fix error handling for http The reject handler were always called no matter if there was an error or not. --- src/Runner.js | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/src/Runner.js b/src/Runner.js index bce498bb..d4ed87fa 100644 --- a/src/Runner.js +++ b/src/Runner.js @@ -157,17 +157,19 @@ function run(transformFile, paths, options) { }) .on('end', () => { temp.open('jscodeshift', (err, info) => { - reject(err); - fs.write(info.fd, contents); - fs.close(info.fd, function(err) { - reject(err); - transform(info.path).then(resolve, reject); + if (err) return reject(err); + fs.write(info.fd, contents, function (err) { + if (err) return reject(err); + fs.close(info.fd, function(err) { + if (err) return reject(err); + transform(info.path).then(resolve, reject); + }); }); }); }) }) .on('error', (e) => { - reject(e.message); + reject(e); }); }); } else if (!fs.existsSync(transformFile)) {