Skip to content

make_full_disasm_for_code + disassemble_all: data-only splits missing macro.inc include #528

@emoose

Description

@emoose

In SH1 we've been pinned to 0.35 for a bit, tried updating to 0.39 and it seems to work fine for main build, but our objdiff build uses --make_full_disasm_for_code --disassemble_all which is acting up a little now.

In yaml we have a .rodata split for data-only .c
- [0x0, .rodata, bodyprog]

in 0.35 using the disasm flags, that made an asm/USA/bodyprog/data/bodyprog.rodata.s file with the .rodata bytes inside (plus .include "macro.inc" line)

With 0.39 we still get that file, but now we also get an asm/USA/bodyprog/bodyprog.s file with the same data as that .rodata.s too, but without .include "macro.inc", causing build fail when it tries to assemble it: https://github.com/Vatuu/silent-hill-decomp/actions/runs/23677794528/job/68984322756

Looks like 0.37 did make a change around data-only splits, noticed that the splits with code+data have the macro.inc include fine too, maybe data splits need extra include line added?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions