Incorrect integrity of transformed files?

[toyobayashi]

asar/lib/filesystem.js

Lines 70 to 94 in c2b4777

	const transformed = options.transform && options.transform(p)
	if (transformed) {
	const tmpdir = await fs.mkdtemp(path.join(os.tmpdir(), 'asar-'))
	const tmpfile = path.join(tmpdir, path.basename(p))
	const out = fs.createWriteStream(tmpfile)
	const readStream = fs.createReadStream(p)
	await pipeline(readStream, transformed, out)
	file.transformed = {
	path: tmpfile,
	stat: await fs.lstat(tmpfile)
	}
	size = file.transformed.stat.size
	} else {
	size = file.stat.size
	}
	// JavaScript cannot precisely present integers >= UINT32_MAX.
	if (size > UINT32_MAX) {
	throw new Error(`${p}: file size can not be larger than 4.2GB`)
	}
	node.size = size
	node.offset = this.offset.toString()
	node.integrity = await getFileIntegrity(p)

asar/lib/filesystem.js

Line 94 in c2b4777

node.integrity = await getFileIntegrity(p)

p is original file path, while transformed file path is

asar/lib/filesystem.js

Line 73 in c2b4777

const tmpfile = path.join(tmpdir, path.basename(p))

[erikian]

I'm not sure if I understand the problem, could you elaborate?

[toyobayashi]

@erikian Sorry for unclear context. I mean, code above shows that the integrity is computed for original file, not for transformed file. If transform options is provided, should it compute transformed file integrity to the node.integrity? Am I right?