Skip to content

[text-auditor] Fix three clear runtime text issues in user-facing validation errors #49572

@github-actions

Description

@github-actions

Text Improvements

The following user-facing text issues were found in the repository. Each is a low-effort fix.

1. Malformed bracket in S3 input validation error

File: x-pack/filebeat/input/awss3/config.go (line 124)
Current text: api_timeout <%v> must be greater than the sqs.wait_time <%v
Suggested fix: api_timeout <%v> must be greater than the sqs.wait_time <%v>
Why: The missing closing > makes the error message look broken and less readable.

2. Grammar error in Metricbeat module validation error

File: metricbeat/helper/elastic/elastic.go (line 150)
Current text: configured metricsets are not an slice for module %s: %v
Suggested fix: configured metricsets are not a slice for module %s: %v
Why: Clear grammar error (an slice) in user-facing error output.

3. Awkward/unclear Google OAuth validation message (same text in two inputs)

Files:

  • x-pack/filebeat/input/httpjson/config_auth.go (line 331)
  • x-pack/filebeat/input/cel/config_auth.go (line 384)

Current text: none of token_url and client credentials can be used, use google.credentials_file, google.jwt_file, google.credentials_json or ADC instead
Suggested fix: token_url and client credentials cannot be used with the Google provider; use google.credentials_file, google.jwt_file, google.credentials_json, or ADC instead
Why: Current phrasing is grammatically awkward and ambiguous (none of X and Y).

Completeness Check

Explicit searches were run for each problem pattern:

  • api_timeout <%v> must be greater than the sqs.wait_time <%v → one runtime occurrence (awss3/config.go:124).
  • configured metricsets are not an slice for module %s: %v / an slice → one runtime occurrence (elastic.go:150), plus one internal code comment (excluded as non-user-facing).
  • none of token_url and client credentials can be used... → two runtime occurrences (httpjson/config_auth.go:331, cel/config_auth.go:384) plus corresponding test expectations.

Suggested Actions

  • Add the missing > in the api_timeout validation error in x-pack/filebeat/input/awss3/config.go.
  • Change an slice to a slice in metricbeat/helper/elastic/elastic.go.
  • Replace the Google OAuth validation text in both httpjson and cel inputs with clearer phrasing, then update matching tests accordingly.

Duplicate Check

Checked:

  • /tmp/previous-findings.json
  • currently open [text-auditor] issues in elastic/beats

These three runtime text problems were not already tracked in open text-auditor issues.


What is this? | From workflow: Text Auditor

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.

  • expires on Mar 26, 2026, 1:43 PM UTC

Metadata

Metadata

Assignees

No one assigned

    Labels

    needs_teamIndicates that the issue/PR needs a Team:* label

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions