NotFound error when trying to view a private item

[sawyerh]

@sskylar When I'm logged out and try to visit a private item's permalink page, it throws a Dropmark::Error::NotFound exception rather than Dropmark::Error::Forbidden (like it does when trying to visit a private collection).

I think this is a bug? This is how I'm writing it:

begin
  @item = Dropmark::Item.find(params[:id])
  @collection = Dropmark::Collection.find(params[:collection_id], include_items: true)
rescue Dropmark::Error::Forbidden => e
  redirect "/login?redirect=#{request.url}"
end

[sskylar]

Not a bug, but I realize that is inconsistent with private collections.

Following the same practice as GitHub, for example try accessing a private GitHub project URL when logged out. You'll get 404 instead of 403, meaning (to you) this does not exist.

I'll think about this more. In the meantime, swap the order of Item.find and Collection.find and you should be good.

For that matter, you don't really need to call Item.find, because the item will already be returned the collection.

[sawyerh]

What do you mean by this?

For that matter, you don't really need to call Item.find, because the item will already be returned the collection.

[sskylar]

include_items: true means you'll already have an array of items, making Item.find redundant.

[sawyerh]

Gotch ya. I guess another issue I'm running across with this is when item.shareable == true and the collection is private. Item.find works, but then Collection.find throws a Dropmark::Error::Forbidden exception