Skip to content

Regression in v2.2.23 when broadly unescaping selectors #159

@koal44

Description

@koal44

I think this regressed in v2.2.23, around commit 6b27300, where selector normalization changed from:

parsed = selectors.

to:

parsed = unescape(selectors).

That seems to have fixed #152 / #153 by unescaping selector text that had already been percent-encoded upstream.

The problem here is that the fix looks too broad and now unescapes valid escaped text inside quoted attribute substring selectors, e.g.

a[href*="is%3Apr"]

against HTML like:

<a href="/dperini/nwsapi/pulls?q=is%3Apr+is%3Aclosed">Closed</a>

That selector used to match, but after the unescape(selectors) change it effectively becomes [href*="is:pr"], which won't match.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions