CSS selector not escaped properly

[KPblCEHblLLl]

nwsapi/src/nwsapi.js

Line 1538 in f1664d8

(element.className ? '.' + escape(element.classList[0]) : ''));

Here a proper MDN: CSS.escape is required. Otherwise a perfectly valid CSS class w-1/3 will throw an error.
I do not know why the escape is used here and will backwards compatibility allow it to be replaced with CSS.escape, but may I suggest to at least additionally wrap with CSS.escape?
Or create any tool to be able to override the escaping for this particular code line. Otherwise it is a hard blocker to use this library. Because it itself creates an invalid selector and then throws an exception.

Btw, thanks for the library :)
Spent some nice time debugging through it

[dperini]

@KPblCEHblLLl
I agree. I like this suggestion, it will help having a standard method in the browsers maintained by their developers instead of a few poly-fills each yielding different results. I will have a look on how to make it fit best, keeping the old one as backward compatibility for browsers missing CSS.escape() method call.

If you have a specific case where the internal escape() methods does things differently than in CSS.escape(), please send the string to be escaped and the resulting escaped string here for review and testing.

Thank you.

[KPblCEHblLLl]

Sure. I faced the issue the moment I introduced tailwindcss into project. The library supplies styling class names like "w-1/2"
https://tailwindcss.com/docs/width

so nwsapi fails to construct 'div.w-1/2' selector

[dperini]

@KPblCEHblLLl
I am going through this needed change/fix as you suggested since the current escape polyfil did not cover expectations.
I believe any browser has a correct CSS.escape implementation now, however to ensure nwsapi has no extra dependency I will leave the correct polyfil as a local backup alternative to avoid forcing an external dependency.
Your suggestion about this core requirement is welcome and appreciated.
Thank you for the precious help and for the time spent debugging.

[vsn4ik]

I suggest considering this implementation ↓
https://github.com/capricorn86/happy-dom/blob/master/packages/happy-dom/src/css/utilities/CSSEscaper.ts