Skip to content

[CoreNFC] Update bindings to Xcode 26.4 Release Candidate#24958

Open
dalexsoto wants to merge 1 commit intoxcode26.4from
dev/alex/xc26.4-CoreNFC
Open

[CoreNFC] Update bindings to Xcode 26.4 Release Candidate#24958
dalexsoto wants to merge 1 commit intoxcode26.4from
dev/alex/xc26.4-CoreNFC

Conversation

@dalexsoto
Copy link
Member

No description provided.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #dc5f104] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: dc5f104cd1b3757f95ba296360457ed3214e2930 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

NET (empty diffs)

✅ API diff vs stable

NET (empty diffs)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: dc5f104cd1b3757f95ba296360457ed3214e2930 [PR build]

@dalexsoto dalexsoto added this to the xcode26.4 milestone Mar 20, 2026
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #dc5f104] Build passed (Build packages) ✅

Pipeline on Agent
Hash: dc5f104cd1b3757f95ba296360457ed3214e2930 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 [CI Build #dc5f104] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

11 tests crashed, 1 tests failed, 92 tests passed.

Failures

❌ dotnettests tests (MacCatalyst)

🔥 Failed catastrophically on VSTS: test results - dotnettests_maccatalyst (no summary found).

Html Report (VSDrops) Download

❌ dotnettests tests (Multiple platforms)

🔥 Failed catastrophically on VSTS: test results - dotnettests_multiple (no summary found).

Html Report (VSDrops) Download

❌ generator tests

🔥 Failed catastrophically on VSTS: test results - generator (no summary found).

Html Report (VSDrops) Download

❌ interdependent-binding-projects tests

🔥 Failed catastrophically on VSTS: test results - interdependent-binding-projects (no summary found).

Html Report (VSDrops) Download

❌ monotouch tests (MacCatalyst)

🔥 Failed catastrophically on VSTS: test results - monotouch_maccatalyst (no summary found).

Html Report (VSDrops) Download

❌ monotouch tests (macOS)

🔥 Failed catastrophically on VSTS: test results - monotouch_macos (no summary found).

Html Report (VSDrops) Download

❌ windows tests

1 tests failed, 2 tests passed.

Failed tests

  • BGen tests/GeneratorTests.BGenTests.Bug17232: Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.Bug16036: Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.UnderlyingFieldType(iOS): Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.ErrorTests.WarnAsError(macOSMobile): Failed: The error 'BI1117' was not found in the output.

  • BGen tests/GeneratorTests.BGenTests.EditorBrowsable(iOS): Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.ErrorTests.GH6863_property(iOS): Failed: The error 'BI1071' was not found in the output.

  • BGen tests/GeneratorTests.BGenTests.Bug27430: Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.ErrorTests.BI1062_NoAsyncMethodRefParameterTest(iOS): Failed: The error 'BI1062' was not found in the output.

  • BGen tests/GeneratorTests.BGenTests.Issue3875("issue3875C.cs","api0__Issue3875_AProtocol"): Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.Bug27986: Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.BindAsTests: Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.NativeEnum(iOS): Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.SnippetAttributesOptimizable: Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.DesignatedInitializer(iOS): Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.ErrorDomain(iOS): Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.SmartEnumWithFramework(iOS): Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.Bug43579: Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.Bug57531: Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.ClassNameCollision(iOS): Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.DelegateParameterAttributes: Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.BackingFieldType(MacCatalyst): Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.ErrorTests.BI1117_classinternal(iOS): Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.ProtocolTests.Members(iOS): Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.ErrorTests.BI1066(iOS): Failed: The error 'BI1066' was not found in the output.

  • BGen tests/GeneratorTests.BGenTests.NoAsyncInternalWrapper(iOS): Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.ErrorTests.BI1113_Bug37527_MissingProperty(iOS): Failed: The error 'BI1113' was not found in the output.

  • BGen tests/GeneratorTests.ErrorTests.BI1077(iOS): Failed: The error 'BI1077' was not found in the output.

  • BGen tests/GeneratorTests.BGenTests.NSApplicationPublicEnsureMethods(macOSMobile): Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.ErrorTests.BI1037(macOSMobile): Failed: The error 'BI1037' was not found in the output.

  • BGen tests/GeneratorTests.BGenTests.NoAvailabilityForAccessors(iOS): Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.BackingFieldType(iOS): Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.DelegatesWithNullableReturnType(iOS): Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.Bug42742: Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.ErrorTests.BI1046(iOS): Failed: The error 'BI1046' was not found in the output.

  • BGen tests/GeneratorTests.ErrorTests.Bug57094Test(iOS): Failed: The error 'BI1014' was not found in the output.

  • BGen tests/GeneratorTests.BGenTests.BMac_With_Hyphen_In_Name(macOSMobile): Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.GeneratedAttributeOnPropertyAccessors2: Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.Bug39614(iOS): Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.RefOutParameters: Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.ErrorTests.BI1041(macOSMobile): Failed: The error 'BI1041' was not found in the output.

  • BGen tests/GeneratorTests.BGenTests.IgnoreUnavailableProtocol: Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.ErrorTests.BI1036(iOS): Failed: The error 'BI1036' was not found in the output.

  • BGen tests/GeneratorTests.BGenTests.Issue19612: Failed: CSC exit code

  • BGen tests/GeneratorTests.BGenTests.PropertyRedefinition: Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.Bug46292(iOS): Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.Issue3875("issue3875B.cs","BProtocol"): Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.ArrayFromHandleBug: Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.ErrorTests.BI1040(macOSMobile): Failed: The error 'BI1040' was not found in the output.

  • BGen tests/GeneratorTests.BGenTests.DisposeAttributeOptimizable: Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.Bug36457: Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.ProtocolDuplicateAbstract(macOSMobile): Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.StrongDictsNativeEnums: Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.VSTS970507: Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.GH5416_method(iOS): Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.ErrorTests.GH6863_method(iOS): Failed: The error 'BI1072' was not found in the output.

  • BGen tests/GeneratorTests.BGenTests.NoAsyncWarningCS0219(iOS): Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.AbstractTypeTest: Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.PropertyRedefinitionMac(macOSMobile): Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.ForcedType: Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.ErrorTests.BI1063_NoDoubleWrapTest(iOS): Failed: The error 'BI1063' was not found in the output.

  • BGen tests/GeneratorTests.BGenTests.Bug27428: Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.NewerAvailabilityInInlinedProtocol(iOS): Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.IsDirectBinding: Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.ErrorTests.BI1117_methodinternal(iOS): Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.TypesInMultipleNamespaces(iOS): Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.XmlDocs(macOSMobile): Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.DelegateWithINativeObjectReturnType: Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.StackOverflow20696157: Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.ErrorTests.BI1062_NoAsyncMethodOutHandlerTest(iOS): Failed: The error 'BI1062' was not found in the output.

  • BGen tests/GeneratorTests.ErrorTests.MissingExportOnProperty(iOS): Failed: The error 'BI1018' was not found in the output.

  • BGen tests/GeneratorTests.BGenTests.Desk79124: Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.ErrorTests.BI1067_1070(iOS): Failed: The error 'BI1067' was not found in the output.

  • BGen tests/GeneratorTests.BGenTests.PreviewAPIs(MacCatalyst): Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.PreviewAPIs(iOS): Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.BMac_Smoke(macOSMobile): Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.NFloatType: Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.ReturnRelease: Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.GHIssue18645_DuplicatedFiled: Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.ErrorTests.BI1062_NoAsyncMethodOutParameterTest(iOS): Failed: The error 'BI1062' was not found in the output.

  • BGen tests/GeneratorTests.BGenTests.ProtocolBindProperty: Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.ErrorTests.WarnAsError(iOS): Failed: The error 'BI1117' was not found in the output.

  • BGen tests/GeneratorTests.BGenTests.Issue3875("issue3875.cs","api0__Issue3875_AProtocol"): Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.Bug29493: Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.ErrorTests.BI1048(iOS): Failed: The error 'BI1048' was not found in the output.

  • BGen tests/GeneratorTests.BGenTests.GHIssue7304: Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.NSCopyingNullability(iOS): Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.Bug18035(iOS): Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.XmlDocs(tvOS): Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.XmlDocs(iOS): Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.ErrorTests.BI1049(iOS): Failed: The error 'BI1049' was not found in the output.

  • BGen tests/GeneratorTests.BGenTests.ObsoletedOSPlatform(iOS): Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.ErrorTests.NoWarn(macOSMobile): Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.ErrorTests.BindAsNullableNSStringArrayError(iOS): Failed: The error 'BI1048' was not found in the output.

  • BGen tests/GeneratorTests.BGenTests.PreviewAPIs(macOSMobile): Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.Bug53076WithModel: Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.ErrorTests.BI1059(iOS): Failed: The error 'BI1084' was not found in the output.

  • BGen tests/GeneratorTests.BGenTests.Bug40282: Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.ProtocolTests.Members(MacCatalyst): Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.ErrorTests.BI1112_Bug37527_WrongProperty(iOS): Failed: The error 'BI1112' was not found in the output.

  • BGen tests/GeneratorTests.BGenTests.Bug35176: Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.Bug15307: Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.INativeObjectArraysInBlocks(iOS): Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.ErrorTests.BI1050_protocol(iOS): Failed: The error 'BI1050' was not found in the output.

  • BGen tests/GeneratorTests.BGenTests.StrongDictSupportTemplatedDicts: Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.GH5416_setter(iOS): Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.GHIssue3869: Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.Bug15283: Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.FieldEnumTests(iOS): Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.GenericNSObjectParameter: Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.Bug57870: Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.ErrorTests.BI1050_model(iOS): Failed: The error 'BI1050' was not found in the output.

  • BGen tests/GeneratorTests.BGenTests.HyphenInName: Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.GHIssue6626: Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.ErrorTests.BindAsNoOutParam(iOS): Failed: The error 'BI1080' was not found in the output.

  • BGen tests/GeneratorTests.BGenTests.PreviewAPIs(tvOS): Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.GHIssue5444: Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.AttributesFromInlinedProtocols(iOS): Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.ErrorTests.BindAsNullableNSNumberArrayError(iOS): Failed: The error 'BI1048' was not found in the output.

  • BGen tests/GeneratorTests.BGenTests.Bug53076: Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.Forum54078: Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.DiamondProtocol: Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.ErrorTests.BI1060(iOS): Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.DelegatesWithPointerTypes(iOS): Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.GHIssue5692: Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.ErrorTests.BI1038(macOSMobile): Failed: The error 'BI1038' was not found in the output.

  • BGen tests/GeneratorTests.ErrorTests.BI1062_NoAsyncMethodRefHandlerTest(iOS): Failed: The error 'BI1062' was not found in the output.

  • BGen tests/GeneratorTests.ErrorTests.BindAsNoMultidimensionalArrays(iOS): Failed: The error 'BI1048' was not found in the output.

  • BGen tests/GeneratorTests.ErrorTests.BI1065(iOS): Failed: The error 'BI1065' was not found in the output.

  • BGen tests/GeneratorTests.ErrorTests.NoWarn(iOS): Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.Bug34042: Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.BothProtectedAndInternal(iOS): Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.Bug31788(macOSMobile): Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.ErrorTests.MissingExportOnProperty(macOSMobile): Failed: The error 'BI1018' was not found in the output.

  • BGen tests/GeneratorTests.BGenTests.INativeObjectsInBlocks(iOS): Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.ErrorTests.BindAsNoRefParam(iOS): Failed: The error 'BI1080' was not found in the output.

  • BGen tests/GeneratorTests.ErrorTests.BI1064(iOS): Failed: The error 'BI1064' was not found in the output.

  • BGen tests/GeneratorTests.BGenTests.GeneratedAttributeOnPropertyAccessors: Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.InternalDelegate: Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.GHIssue9065_Sealed: Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.ErrorTests.BI1042(iOS): Failed: The error 'BI1042' was not found in the output.

  • BGen tests/GeneratorTests.BGenTests.GenericStrongDictionary: Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.ErrorTests.BindAsNullableNSValueArrayError(iOS): Failed: The error 'BI1048' was not found in the output.

  • BGen tests/GeneratorTests.ErrorTests.BI1117(iOS): Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.ProtocolWithBaseTypeButNoModel(MacCatalyst): Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.ErrorTests.StrongDictionaryErrors(MacCatalyst): Failed: The error 'BI1121' was not found in the output.

  • BGen tests/GeneratorTests.BGenTests.XmlDocs(MacCatalyst): Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.Bug24078: Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.VirtualWrap(iOS): Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.ErrorTests.BI1039(macOSMobile): Failed: The error 'BI1039' was not found in the output.

  • BGen tests/GeneratorTests.BGenTests.CSharp10Syntax: Failed: BGen failed with exit code 1: build

  • BGen tests/GeneratorTests.BGenTests.ReleaseAttribute(iOS): Failed: BGen failed with exit code 1: build

Html Report (VSDrops) Download

❌ Tests on macOS Monterey (12) tests

🔥 Failed catastrophically on VSTS: test results - mac_monterey (no summary found).

Html Report (VSDrops) Download

❌ Tests on macOS Ventura (13) tests

🔥 Failed catastrophically on VSTS: test results - mac_ventura (no summary found).

Html Report (VSDrops) Download

❌ Tests on macOS Sonoma (14) tests

🔥 Failed catastrophically on VSTS: test results - mac_sonoma (no summary found).

Html Report (VSDrops) Download

❌ Tests on macOS Sequoia (15) tests

🔥 Failed catastrophically on VSTS: test results - mac_sequoia (no summary found).

Html Report (VSDrops) Download

❌ Tests on macOS Tahoe (26) tests

🔥 Failed catastrophically on VSTS: test results - mac_tahoe (no summary found).

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 6 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 11 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ sharpie: All 1 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

macOS tests

Pipeline on Agent
Hash: dc5f104cd1b3757f95ba296360457ed3214e2930 [PR build]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants