From c163257a0975653a0f704fd4ab4f27264e1b3db5 Mon Sep 17 00:00:00 2001 From: jdfandino10 Date: Mon, 6 Mar 2017 23:17:04 -0500 Subject: [PATCH] code review --- package.json | 1 + public/js/main.js | 1 + public/js/map.js | 1 + src/components/app.js | 1 + src/components/crime_adder.js | 1 + src/components/crime_displayer.js | 4 +++- src/components/crime_map.js | 1 + src/components/crime_selector.js | 1 + src/components/crime_type_selector.js | 1 + src/components/description.js | 1 + src/components/reported_selector.js | 1 + src/index.js | 1 + 12 files changed, 14 insertions(+), 1 deletion(-) diff --git a/package.json b/package.json index ba1afab..8eb3550 100644 --- a/package.json +++ b/package.json @@ -30,6 +30,7 @@ "babel-preset-stage-1": "^6.1.18", "lodash": "^3.10.1", "react": "^0.14.3", + "react-addons-shallow-compare": "^15.4.2", "react-dates": "^7.0.1", "react-dom": "^0.14.3", "react-google-maps": "^6.0.1", diff --git a/public/js/main.js b/public/js/main.js index c902945..0a0d380 100644 --- a/public/js/main.js +++ b/public/js/main.js @@ -88,3 +88,4 @@ $(document).ready(function () $("#panelCrear").hide(); }); }); +//Chevere la paginación \ No newline at end of file diff --git a/public/js/map.js b/public/js/map.js index 598accf..b252bcb 100644 --- a/public/js/map.js +++ b/public/js/map.js @@ -38,6 +38,7 @@ function initMap() } } } +//Chevere el uso del google maps API // function initMap() { // map = new google.maps.Map(document.getElementById('map'), { // center: { lat: 20, lng: -160 }, diff --git a/src/components/app.js b/src/components/app.js index 2774e41..8caa6a8 100644 --- a/src/components/app.js +++ b/src/components/app.js @@ -93,3 +93,4 @@ class App extends Component { } export default App; +//Muy ordenado y bien hecho \ No newline at end of file diff --git a/src/components/crime_adder.js b/src/components/crime_adder.js index c7286ea..d37a2f3 100644 --- a/src/components/crime_adder.js +++ b/src/components/crime_adder.js @@ -136,3 +136,4 @@ class CrimeAdder extends Component { } export default CrimeAdder; +//Ordenado y bien hecho \ No newline at end of file diff --git a/src/components/crime_displayer.js b/src/components/crime_displayer.js index ec1ddc5..8e98821 100644 --- a/src/components/crime_displayer.js +++ b/src/components/crime_displayer.js @@ -138,4 +138,6 @@ class CrimeDisplayer extends Component { } } - export default CrimeDisplayer; + export default CrimeDisplayer; //ojo la indentacion + +//en general ordenado y bien hecho diff --git a/src/components/crime_map.js b/src/components/crime_map.js index 9f580dd..66c2d73 100644 --- a/src/components/crime_map.js +++ b/src/components/crime_map.js @@ -93,3 +93,4 @@ class CrimeMap extends Component { } export default CrimeMap; +//Bien, ordenada la separacion dela clase y el listener del map \ No newline at end of file diff --git a/src/components/crime_selector.js b/src/components/crime_selector.js index cd0d1dd..d2879e5 100644 --- a/src/components/crime_selector.js +++ b/src/components/crime_selector.js @@ -30,3 +30,4 @@ CrimeSelector.propTypes = { }; export default CrimeSelector; +//Ordenado, cort, concreto. Bueno especificar los tipos de los atributos props \ No newline at end of file diff --git a/src/components/crime_type_selector.js b/src/components/crime_type_selector.js index 8bd8437..e63797d 100644 --- a/src/components/crime_type_selector.js +++ b/src/components/crime_type_selector.js @@ -28,3 +28,4 @@ CrimeTypeSelector.propTypes = { }; export default CrimeTypeSelector; +//Ordenado, cort, concreto. Bueno especificar los tipos de los atributos props \ No newline at end of file diff --git a/src/components/description.js b/src/components/description.js index b54a523..850032f 100644 --- a/src/components/description.js +++ b/src/components/description.js @@ -25,3 +25,4 @@ Description.propTypes = { }; export default Description; +//Ordenado, cort, concreto. Bueno especificar los tipos de los atributos props \ No newline at end of file diff --git a/src/components/reported_selector.js b/src/components/reported_selector.js index 0862468..1f3b897 100644 --- a/src/components/reported_selector.js +++ b/src/components/reported_selector.js @@ -30,3 +30,4 @@ ReportedSelector.propTypes = { }; export default ReportedSelector; +//Ordenado, cort, concreto. Bueno especificar los tipos de los atributos props diff --git a/src/index.js b/src/index.js index 532d23f..9188da6 100644 --- a/src/index.js +++ b/src/index.js @@ -6,3 +6,4 @@ import App from './components/app'; ReactDOM.render(, document.querySelector('.react')); +//Bien \ No newline at end of file